New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851940 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocked on:
issue 856176

Blocking:
issue webrtc:9402



Sign in to add a comment

Remove googBeamforming and googArrayGeometry

Project Member Reported by maxmorin@chromium.org, Jun 12 2018

Issue description

Currently, they sit at 0.000002% and 0.000000% respectively. googBeamforming can't be done without googArrayGeometry, so I assume all the googBeamforming users are setting it to false. We should get rid of this stuff, since it's not used and exposes a bunch of rarely exercised code in WebRTC.
 
Cc: aluebs@chromium.org
Cc: saza@chromium.org
Blocking: webrtc:9402
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4131d301e2353a932e7adcddedbd64cea14664

commit aa4131d301e2353a932e7adcddedbd64cea14664
Author: Max Morin <maxmorin@chromium.org>
Date: Wed Jun 13 17:50:59 2018

Remove implementation of googBeamforming.

Removes the implementation, leaves the web-facing stuff.

Bug:  851940 , 851959
Change-Id: I9a7ef1f14ecd67a6d56d7f63bf35c16813ee626c
Reviewed-on: https://chromium-review.googlesource.com/1097134
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566899}
[modify] https://crrev.com/aa4131d301e2353a932e7adcddedbd64cea14664/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/aa4131d301e2353a932e7adcddedbd64cea14664/content/renderer/media/stream/media_stream_audio_processor_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8

commit 0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Jun 25 17:51:59 2018

Remove googBeamforming and googArrayGeometry.

Drive-by fix some lint.

Bug:  851940 ,  856176 
Change-Id: Ia42c0902b58cd278afc2c4703a50982204ef75b8
Reviewed-on: https://chromium-review.googlesource.com/1099235
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570088}
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/media_stream_audio_processor_options.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/mock_constraint_factory.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/content/renderer/media/stream/user_media_client_impl_unittest.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/media/base/audio_point.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/media/base/audio_point.h
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/media/base/audio_point_unittest.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/third_party/blink/public/platform/web_media_constraints.h
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/third_party/blink/renderer/modules/mediastream/user_media_request.cc
[modify] https://crrev.com/0ab64718fc3ad72ce22b284ab1c0791c2ba4cfc8/third_party/blink/renderer/platform/exported/web_media_constraints.cc

Blockedon: 856176
Labels: -Pri-1 Pri-3
Status: Assigned (was: Started)
The (very little) remaining work is blocked on  issue 856176 . This issue is dealt with enough to not block the APM work, so lowering priority.
I think we can close this, since for practical purposes they have been removed.
Actual removal will come when we remove support for the old constraints syntax in getUserMedia().
Status: Fixed (was: Assigned)
SGTM

Sign in to add a comment