New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851937 link

Starred by 10 users

Clear auto-opening settings is missing from settings

Project Member Reported by marcore@chromium.org, Jun 12 2018

Issue description

Chrome version: 67.0.3396.62 (Official Build) (64-bit) (cohort: Stable)
OS version: Windows
Case#: 16087036

Description: in the chrome://settings/downloads there is no more the "Open certain file types automatically after downloading"


Steps to reproduce: 
1) download any file type that can be opened by a program on the pc
2) flag "always open files of this type"

Current Behavior / Reproduction: 
the user is unable to erase the "Open certain file types automatically after downloading"

Expected Behavior: 
being able to erase the automatic open
video: https://drive.google.com/open?id=1uNFrq0jkMGJ5_adfBTmJJ_eNNv6UOlSx
bisect logs: https://drive.google.com/open?id=1nHrqzbD4HOZpWoxb3mj_ANPzkPMhMW4z

You are probably looking for a change made after 546855 (known good), but no later than 546909 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/263c2c2f03e625ce0447132e56ece4269fc93ef1..b76357fe3afc9fb391b9bebaae79b2251ee2c6b2
it could be https://chromium.googlesource.com/chromium/src/+/c66a07a6bacf15c57245475fba73f1eb50f170fd


 
Cc: pbomm...@chromium.org steve...@chromium.org gov...@chromium.org dpa...@chromium.org
Components: UI>Browser>Downloads
Labels: ReleaseBlock-Stable M-68 M-69 Target-67 FoundIn-67 Target-68 FoundIn-68 FoundIn-69
Owner: baileyberro@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue with latest Chrome stable i.e., 67.0.3396.87 and this is a regression as stated in bug report.

bisect range :
You are probably looking for a change made after 546899 (known good), but no later than 546900 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/d869c3ae7fb8a96bee98423c312159ffedddd423..c66a07a6bacf15c57245475fba73f1eb50f170fd

Comment 2 by dpa...@chromium.org, Jun 13 2018

@stevenjb: It seems to me that the closing </neon-animatable> tag at [1] is causing the problem. Instead it should be moved after line 78. Otherwise the autoOpenDownloads_ block is not part of the "default" page, causing it to never be shown.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/967160/15/chrome/browser/resources/settings/downloads_page/downloads_page.html#66

Comment 3 by gov...@chromium.org, Jun 13 2018

M67 has been out since 05/29, currently at 50% for Windows and Mac, 100% Linux. Plan is to ramp up to 100% tomorrow if all goes well. And at the moment, there is no plan to do stable respin unless extremely critical issues arise.

baileyberro@, is this indeed M67 stableb blocker for further roll out? Is there any workaround available for this?
Cc: zentaro@chromium.org

Comment 5 by gov...@chromium.org, Jun 13 2018

Per internal mail thread, we're not considering this as M67 stable blocker for further roll out.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fddcda21db36d32f39ec5cc1fa0589c80bc0f8f2

commit fddcda21db36d32f39ec5cc1fa0589c80bc0f8f2
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Jun 14 16:31:41 2018

Move Auto Open Downloads block into neon-animatable tag

This change fixes a  https://crbug.com/851937  where users are unable to
clear auto-opening downloads settings.

Bug:  chromium:851937 
Test: verified manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I263ef9497a8a9b298a3514404fc3f31a61393687
Reviewed-on: https://chromium-review.googlesource.com/1099693
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567299}
[modify] https://crrev.com/fddcda21db36d32f39ec5cc1fa0589c80bc0f8f2/chrome/browser/resources/settings/downloads_page/downloads_page.html

Labels: -ReleaseBlock-Stable Merge-Request-68
Status: Fixed (was: Assigned)
Labels: TE-Verified-M69 TE-Verified-69.0.3461.2
Tested the issue on Windows 10, Debian Rodete and Mac 10.13.3 using Chrome version M69 - 69.0.3461.2 as per the issue mentioned in original comment. Observed that issue is working as intended ('Open certain file types automatically after downloading' is displayed in chrome://settings/downloads). Hence adding TE-Verified label. Attached the screenshot for reference.

Thank you!
851937.png
91.1 KB View Download
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 15 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to M68. Branch:3440
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec13ed2cad26036587680bb51236e76007c845a

commit 4ec13ed2cad26036587680bb51236e76007c845a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jun 18 15:47:30 2018

Move Auto Open Downloads block into neon-animatable tag

This change fixes a  https://crbug.com/851937  where users are unable to
clear auto-opening downloads settings.

Bug:  chromium:851937 
Test: verified manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I263ef9497a8a9b298a3514404fc3f31a61393687
Reviewed-on: https://chromium-review.googlesource.com/1099693
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567299}(cherry picked from commit fddcda21db36d32f39ec5cc1fa0589c80bc0f8f2)
Reviewed-on: https://chromium-review.googlesource.com/1104637
Cr-Commit-Position: refs/branch-heads/3440@{#395}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/4ec13ed2cad26036587680bb51236e76007c845a/chrome/browser/resources/settings/downloads_page/downloads_page.html

Labels: TE-Verified-M68 TE-Verified-68.0.3440.33
Tested the issue on Windows 10, Debian Rodete and Mac 10.13.3 using Chrome version M68 - 68.0.3440.33 as per the issue mentioned in original comment. Observed that issue is working as intended ('Open certain file types automatically after downloading' is displayed in chrome://settings/downloads). Hence adding TE-Verified label. Attached the screenshot for reference.

Thank you!
851937-M68.png
117 KB View Download
Issue 853734 has been merged into this issue.

Comment 15 by lubok...@gmail.com, Jun 25 2018

No possible choose option "Open certain file types automatically after downloading" - "clear"
this option do not exist in new chrome :-(
 Issue 855777  has been merged into this issue.
Labels: Hotlist-ConOps
 Issue 855947  has been merged into this issue.
Please confirm if [Open certain file types automatically after downloading] is rolled back to Chrome Stable 68 under chrome://settings/downloads since we could no have found this configuration from Chrome Beta 68 as well as from Chrome Canary 70.

Per #13 the fix should be in 68. Could you please clarify akihiros@? The clear setting should only appear after selecting 'always open files of this type' on a downloaded file. Thanks

Sign in to add a comment