New issue
Advanced search Search tips

Issue 851929 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

Text Syncing is not properly displayed in Recent tabs

Project Member Reported by pmadalla@chromium.org, Jun 12 2018

Issue description

App Version: 69.0.3456.0 Canary
iOS Version: 10.3.3,iOS 11.4
Device: iPhone,iPad

Steps to reproduce:
  1.  Launch chrome.
  2.  Sign in to chrome.
  3.  Tap on tabswithcer > tap on Other devices icon(while the data is syncing)

Observed results:
Observe that Syncing text is not properly displayed

Expected results:
Syncing text should be displayed properly

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA

Link to video/image:
https://drive.google.com/file/d/1C8Jmu4h79JqF02R8IHLz7EkydkaOA1YX/view?usp=sharing


 

Comment 1 by marq@chromium.org, Jun 13 2018

Labels: -MS-Recent-Tabs MS-Tab-Grid Q2
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by edchin@chromium.org, Jun 13 2018

Cc: edchin@chromium.org
Owner: sczs@chromium.org
Components: UI>Browser>Mobile>RecentTabs

Comment 4 by sczs@chromium.org, Jun 22 2018

Labels: -MS-Tab-Grid -S-Recent-Tabs-In-Grid MS-Recent-Tabs
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2867a7160ab2a2b19ba82928b04908edcaacd0d5

commit 2867a7160ab2a2b19ba82928b04908edcaacd0d5
Author: sczs <sczs@chromium.org>
Date: Tue Jul 03 15:46:18 2018

[ios] Fixes small Collections constraint issues.

- Changes the disclore headerFooter subtitle label CompressionResistancePriority to prevent it
being compressed when refreshing the Cell.
- Deletes some un-needed constraints that weren't playing nicely with the TableView dynamic sizing,
causing broken constraints.

Bug:  851929 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifd641c1d7c227592d4767d9af1874dfcb3e556ca
Reviewed-on: https://chromium-review.googlesource.com/1123335
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572235}
[modify] https://crrev.com/2867a7160ab2a2b19ba82928b04908edcaacd0d5/ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.mm
[modify] https://crrev.com/2867a7160ab2a2b19ba82928b04908edcaacd0d5/ios/chrome/browser/ui/table_view/cells/table_view_activity_indicator_header_footer_item.mm
[modify] https://crrev.com/2867a7160ab2a2b19ba82928b04908edcaacd0d5/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Still reproduced with iPhoneX, iOS12 M69.0.3486.0 canary
Same steps as originally reported.
Status: Fixed (was: Assigned)
Checked with Srikanth, and he verified that this is fixed on the latest beta and canary.
Status: Verified (was: Fixed)

Sign in to add a comment