New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to disable WiFi in login screen

Project Member Reported by kebalaji@chromium.org, Jun 12 2018

Issue description

Chrome Version: 69.0.3455.1/10774.0.0 dev channel Kip, Jerry, Celes
OS: Chrome OS

What steps will reproduce the problem?
(1)In Sign-out screen, try to disable WiFi Network 

Actual: Unable to disable WiFi in sign-out screen 
Expected: Should be able to disable WiFi

This is a Regression issue as same is working fine in 69.0.3452.0/10773.0.0 dev 

@Stevenjb: Please confirm the issue
 
ActualWiFI.mp4
8.3 MB View Download
ExpectedWiFI.mp4
6.0 MB View Download
Cc: avkodipelli@chromium.org pucchakayala@chromium.org
What do you mean by "sign out screen"?

Status: Started (was: Assigned)
Summary: Regression: Unable to disable WiFi in login screen (was: Regression: Unable to disable WiFi in sign-out screen )
Looks like this is in the login screen. Probably an artifact of disabling the UI for secondary users.

Comment 4 by cindyb@chromium.org, Jun 12 2018

What is the scope and impact of this for Dev? Can you provide justification for blocking? Thanks!
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
It could prevent logging in, so I think RBD is correct. I'll have a fix up for review tonight.

Comment 7 by ajha@chromium.org, Jun 13 2018

Labels: -ReleaseBlock-Beta ReleaseBlock-Dev
RBD as per C#5.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd8eadcdfb36c1b0c9166c33f96952912f8112cf

commit bd8eadcdfb36c1b0c9166c33f96952912f8112cf
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jun 13 17:46:39 2018

Tray > Network: Enable toggles in login screen

Regression introduced in:
https://chromium-review.googlesource.com/1089585

Toggles should only be disabled for secondary users when logged in,
not in the login screen.

Bug:  851893 
Change-Id: Ia77b26c6217ad184ecb765b3c8f3a5fa4cccb6ea
Reviewed-on: https://chromium-review.googlesource.com/1098308
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566892}
[modify] https://crrev.com/bd8eadcdfb36c1b0c9166c33f96952912f8112cf/ash/system/network/network_list.cc

Status: Fixed (was: Started)

Sign in to add a comment