Improve Done Animation + New Tab w selected tab outside of the view - Tab Switcher |
||||||||
Issue descriptionWe would like to do some tweaks to this animation that appears: - When Pressing Done in the Tab Switcher - When creating a New Tab from the Tab Switcher but the selected tab is outside of the view. Current implementation see attachment. The tweaks are: - Ensure that the new tab animates with rounded corners (13pt) - Fade the old tab to black when the new is animating in. - Duration 200 ms - Start the animation from a lower Scale (e.g. 0.75) - Disable the repositioning of the toolbars, keep them in place. - Fade out the top and bottom toolbar - Duration 200 ms - Ensure that the Tab that appears, appears on top of other components. Refer to the "Master" animation that acts as a guide (e.g. for timing and tweening): https://bugs.chromium.org/p/chromium/issues/detail?id=850507
,
Jun 13 2018
,
Jun 26 2018
,
Jun 27 2018
,
Jul 10
,
Jul 16
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0922d466dd731f062c2a94c2b8a6273f8b3c0415 commit 0922d466dd731f062c2a94c2b8a6273f8b3c0415 Author: Mark Cogan <marq@google.com> Date: Tue Jul 17 09:12:53 2018 [iOS] Tune reduced motion tab grid transition. Per the bug, add corner rounding and change the scale of the reduced motion animation. Note that this CL uses 26px corner radius for better visibility given how brief the animation is. Bug: 851871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f2c3b02ce53abed3570f33a09017ee7a9273ed1 Reviewed-on: https://chromium-review.googlesource.com/1138618 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#575589} [modify] https://crrev.com/0922d466dd731f062c2a94c2b8a6273f8b3c0415/ios/chrome/browser/ui/tab_grid/transitions/reduced_motion_animator.mm
,
Jul 17
Some of the requested changes (tab grid toolbar fades, for example) have landed or will land as part of other animation changes. The CL in #7 adds the scale changed (from 80% to 75%) and corner rounding.
,
Jul 31
Verified on 70.0.3508.0 Canary, iPhone6 iOS 10.3.3, iPhone X iOS 11.4.1, iPad Air iOS11.4 Tested the tweaks in comment #0: Rounded corners are shown, Top and bottom toolbar fade out, Tab that appears, appears on top of other components. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by marq@chromium.org
, Jun 12 2018