New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851870 link

Starred by 3 users

Issue metadata

Status: ExternalDependency
Owner:
OOO until 2019-01-24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Problems with GLSL structs and certain Android devices

Reported by michael....@human-interactive.org, Jun 12 2018

Issue description

Steps to reproduce the problem:
Open the testcase: https://jsfiddle.net/f2Lommf5/6828/

What is the expected behavior?
You should see a green plane on the lower right of the screeen. That means the shader is executed correctly.

What went wrong?
In error cases, you see a red plane. If you have in your GLSL code a function with an inout struct parameter, modifcation to its values within the function are not possible. That only happens when the code is executed in high precision. lowp and mediump works fine.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 66.0.3359.158  Channel: stable
OS Version: 7.0.0
Flash Version: 

Tested with  LG Aristo and LG Fiesta (both have a Qualcomm Snapdragon 425). It does not happen with other devices like a Pixel 1 or Pixel 2. More information about the issue: https://github.com/mrdoob/three.js/issues/14137
 
Labels: Needs-triage-Mobile
Cc: jbanavatu@chromium.org
Labels: Target-67 RegressedIn-66 has-Bisect Triaged-Mobile M-69 FoundIn-67 Target-69 Target-68 FoundIn-68 FoundIn-69
Status: Untriaged (was: Unconfirmed)
Tested the issue using #66.0.3359.158 on Samsung J7 7.0 and able to reproduce the issue as per the steps mentioned below.
 
Steps Followed:
1. Launch Chrome.
2. Navigate to https://jsfiddle.net/f2Lommf5/6828/
3. Observed the red plane.

Chrome versions tested:
67.0.3396.87(Stable), 69.0.3456.0(Canary)

OS:
Android 7.0.0

Android Devices: Samsung J7

Unable to provide tool bisect & manual change log as we are getting no commits message for following builds.
Good Build - 66.0.3359.156
Bad Build - 66.0.3359.158

Hence marking it as Untriaged for more inputs.


Thanks!

Cc: ligim...@chromium.org pnangunoori@chromium.org
Labels: -has-Bisect Needs-Bisect
The bisect seems to be incorrect, try to check in M66 builds before branching.
Labels: Needs-Feedback
Tested the issue on reported #66.0.3359.158, stable #67.0.3396.87 and Canary 69.0.3462.0 on Samsung J7 Android 7.0  and LG G5. We are unable to reproduce this issue.

Attaching screen-cast for the same.

michael @ Could you please update chrome to latest #67.0.3396.87 version and let us know if issue persists.

Thanks!
851870.mp4
4.6 MB View Download

Comment 6 by mema...@gmail.com, Jun 18 2018

As I commented on https://bugs.chromium.org/p/chromium/issues/detail?id=851873: the Samsung J7 appears to have either a Qualcomm MSM8939 Snapdragon 615 (with Adreno 405 GPU) or Exynos 7580 Octa (with Mali-T720MP2) depending on the exact model. This issue appears to manifest on phones run by a Qualcomm Snapdragon 425 (with Adreno 308 GPU)

I've been testing on an LG Aristo and an LG Fiesta. The overarching issue has been reported on 15 different specific devices from 7 manufacturers[1], most (all?) of which have the same Snapdragon 425

[1]: https://github.com/mrdoob/three.js/issues/14137#issue-326298141

Comment 7 by mema...@gmail.com, Jun 18 2018

(and the LG G5 appears to use a Qualcomm MSM8996 Snapdragon 820 with Adreno 530)

Comment 8 by mema...@gmail.com, Jun 18 2018

Repeated from https://github.com/mrdoob/three.js/issues/14137#issuecomment-397094343

Verified that this issue does occur with the latest Chrome version available (67.0.3396.87).

Comment 9 by mema...@gmail.com, Jun 18 2018

Screenshot_2018-06-18-14-04-12.png
136 KB View Download
Screenshot_2018-06-18-14-04-49.png
167 KB View Download
Screenshot_2018-06-18-14-04-56.png
156 KB View Download
Screenshot_2018-06-18-14-05-03.png
168 KB View Download
Screenshot_2018-06-18-14-05-07.png
165 KB View Download
Labels: -Needs-Feedback -Needs-Bisect -RegressedIn-66 -Target-67 -Target-68
Tested the issue on latest stable #67.0.3396.87 on samsung J5(2016) Android 7.1.0 and able to reproduce as per the steps mentioned below.

Steps Followed:
1. Launch Chrome.
2. Navigate to https://jsfiddle.net/f2Lommf5/6828/
3. Observed the red plane.

Observing the same behavior since M60. Untriaged for further inputs.Hence removing Needs-Bisect label.

Please navigate to below link for log's and screen cast and screenshot of the error --
go/chrome-androidlogs/851870
 
Issue is seen in M69-69.0.3465.0 as well.

Note: Updating the labels accordingly.

Thanks!!

Comment 11 by kbr@chromium.org, Jun 19 2018

Labels: GPU-Qualcomm

Comment 12 by kbr@chromium.org, Jun 30 2018

Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
Submitter: have created a WebGL conformance test for this in this pull request:
https://github.com/KhronosGroup/WebGL/pull/2663

It fails on the affected phone.

Status: ExternalDependency (was: Assigned)
New graphics tests for Android including this functionality are in review:
https://android-review.googlesource.com/718028

These will prevent future phones from regressing in this area. Unfortunately, there's nothing we can do in Chrome to work around this issue on the affected devices.

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f64860d89fdb6d3397286e722b42f18c7df7db7

commit 6f64860d89fdb6d3397286e722b42f18c7df7db7
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Jul 21 02:54:54 2018

Roll WebGL a5c263c..21dbf06

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a5c263c..21dbf06

Bug:  830901 , 851870, 851873,  859400 ,  866089 
Tbr: zmo@chromium.org
Tbr: kainino@chromium.org
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Change-Id: Icef8ddc970ccb6653e95920c28b4d003d1b27100
Reviewed-on: https://chromium-review.googlesource.com/1144306
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577063}
[modify] https://crrev.com/6f64860d89fdb6d3397286e722b42f18c7df7db7/DEPS
[modify] https://crrev.com/6f64860d89fdb6d3397286e722b42f18c7df7db7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/6f64860d89fdb6d3397286e722b42f18c7df7db7/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Sign in to add a comment