New issue
Advanced search Search tips

Issue 851868 link

Starred by 1 user
Status: Fixed
Owner:
gyuyoung...@lge.com
Closed: Jul 5
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 842019
Blocking:
issue 857295



Sign in to add a comment

Release more memory in RenderThreadImpl::ReleaseFreeMemory()

Project Member Reported by gyuyoung...@chromium.org, Jun 12 2018 
For low-end devices(E.g Android Go devices), it would be good if we release memory as much as possible. As one of them, I've landed #1049414, #1084369 though, they have caused trouble on the perf bots. This bug will find a proper solution to release more memory in RenderThreadImpl::ReleaseFreeMemory().

Comment 2 by gyuyoung...@chromium.org, Jun 12 2018

Owner: gyuyoung...@chromium.org
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/166b13e9240000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/15ad0465240000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/15b37ad9240000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14c739e9240000
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11c07cf9240000
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13ed04f9240000

'unicode' object has no attribute 'get'
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14897055240000
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Jun 14 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/16dec4ad240000
Project Member

Comment 19 by 42576172...@developer.gserviceaccount.com, Jun 15 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/118bd8b5240000
Project Member

Comment 21 by 42576172...@developer.gserviceaccount.com, Jun 15 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14207cf9240000
Project Member

Comment 23 by 42576172...@developer.gserviceaccount.com, Jun 15 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/16bf756d240000
Project Member

Comment 25 by 42576172...@developer.gserviceaccount.com, Jun 15 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/179a3ba5240000

'unicode' object has no attribute 'get'
Project Member

Comment 27 by 42576172...@developer.gserviceaccount.com, Jun 15 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/151aa3d9240000
Project Member

Comment 29 by 42576172...@developer.gserviceaccount.com, Jun 16 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/148cee0d240000

Comment 30 by gyuyoung...@chromium.org, Jun 17 2018

Status: Started (was: Untriaged)
Project Member

Comment 32 by 42576172...@developer.gserviceaccount.com, Jun 18 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12a32063240000
Project Member

Comment 34 by 42576172...@developer.gserviceaccount.com, Jun 18 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12d2099d240000
Project Member

Comment 36 by 42576172...@developer.gserviceaccount.com, Jun 18 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14c18add240000
Project Member

Comment 37 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67dc1b416c296c095015eb0413ba1c0361d115fe

commit 67dc1b416c296c095015eb0413ba1c0361d115fe
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Mon Jun 18 16:13:02 2018

Reland: Call blink::WebMemoryCoordinator::OnPurgeMemory in RenderThreadImpl::ReleaseFreeMemory - 2

This reverts commit cdd97e247777254849ee41adb8efd25f52e48df3.

After perf-bot reported a regression in timeToFirstMeaningfulPaint,
timeToFirstContentfulPaint, and timeToFirstPaint on android nexus5,
the original CL was reverted. However, the regression looks reasonable
because ReleaseMemory could be called before FCP and FMP came on low-end
devices if the website needs to use much memory. I guess that the regression
caused because the test website(edition.cnn.com) was consuming too much memory
on the mobile device.

Bug:  850977 ,  851868 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc8e5f24c114947fe8d186f699d0457ea82b7416
Reviewed-on: https://chromium-review.googlesource.com/1096921
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#568023}
[modify] https://crrev.com/67dc1b416c296c095015eb0413ba1c0361d115fe/content/renderer/render_thread_impl.cc

Comment 38 by gyuyoung...@chromium.org, Jun 28 2018

Blocking: 857295

Comment 39 by gyuyoung...@chromium.org, Jul 5

Status: Fixed (was: Started)
I think this bug was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1096921. I'd like to close this bug.

Comment 40 by gyuyoung...@lge.com, Aug 31

Owner: gyuyoung...@lge.com
►

Sign in to add a comment