Regression:Able to see 'Remove selected items' overlay even when none of the items are selected under chrome://history
Reported by
vineetha...@etouch.net,
Jun 12 2018
|
||
Issue descriptionChrome Version: 69.0.3455.0 (Official Build)Revision f981d5ba6963015157ac5faa8090cd22bec65a3c-refs/branch-heads/3455@{#1} (32/64-bit) OS: Mac(10.12.6,10.13.1,10.13.5,10.13.6), Windows(7,8,8.1,10) and Linux(14.04) OS Pre-condition: There should be atleast one entry under chrome://history/. What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://history/. (2)Press Ctrl+A so that all entries get selected and toolbar selection overlay with 'Cancel' and 'Delete' button is displayed. (3)Click on the 'x' button on the toolbar to close the overlay(Observe that all entries get de-selected). (4)Now click on 'Chrome history' and press Shift+Tab once and press Spacebar/Enter and observe. Actual Result: Able to see 'Remove selected items' overlay even when none of the items are selected under chrome://history Expected Result: Should not be able to see 'Remove selected items' overlay when no items are selected under chrome://history This is regression issue broken in ‘M-69’ and providing the bisect using per-revision bisect, Good build: 69.0.3451.0(Revision: 564769) Bad build : 69.0.3452.0(Revision: 565143) You are probably looking for a change made after 564800 (known good), but no later than 564801 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/75622996bb6cbae10d346f0ecd43e4b0b0508899..2d16b80465674a158f0c14ecbe16f47744e2c0da Suspect: https://chromium.googlesource.com/chromium/src/+/2d16b80465674a158f0c14ecbe16f47744e2c0da @calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31414f90a35d99834cbe2c96a95a9abb7012448d commit 31414f90a35d99834cbe2c96a95a9abb7012448d Author: Christopher Lam <calamity@chromium.org> Date: Wed Jun 13 08:50:23 2018 [cr-toolbar-selection-overlay] Hide toolbar when showing overlay. This CL fixes an issue where the overlay didn't hide the toolbar properly so it could still be tabbed to, and a corresponding problem where overlay buttons could be tabbed to when not visible. Bug: 851835 , 851864 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1562211745c2373ee64a85936953137f2541ae48 Reviewed-on: https://chromium-review.googlesource.com/1098420 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#566763} [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/chrome/browser/resources/md_bookmarks/toolbar.html [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/chrome/browser/resources/md_history/history_toolbar.html [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js [modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jun 14 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rbasuvula@chromium.org
, Jun 12 2018Labels: ReleaseBlock-Stable