The function is only used for sync-internals and for unit-tests, its name should reflect that.
i will take this issue.
Cool, thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c72faf2490896d21a6d46ef9f25c73684269b1a commit 5c72faf2490896d21a6d46ef9f25c73684269b1a Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Thu Jun 14 00:20:24 2018 Rename ModelTypeSyncBridge::GetAllData() Rename GetAllData() to GetAllDataForDebugging(). The function is only used for Sync Node Browser of chrome://sync-internals and for unit-tests, it's name should reflect that. Bug: 851859 Change-Id: I5a73bf405a8e0aca55adb4ca39ee7fdfad813c07 Reviewed-on: https://chromium-review.googlesource.com/1097049 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#567058} [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/chrome/browser/chromeos/printing/printers_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/chrome/browser/chromeos/printing/printers_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/consent_auditor/consent_sync_bridge_impl.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/consent_auditor/consent_sync_bridge_impl.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/consent_auditor/consent_sync_bridge_impl_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/history/core/browser/typed_url_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/history/core/browser/typed_url_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/history/core/browser/typed_url_sync_bridge_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/reading_list/core/reading_list_model_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/reading_list/core/reading_list_store.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/reading_list/core/reading_list_store.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/device_info/device_info_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/device_info/device_info_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/device_info/device_info_sync_bridge_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model/fake_model_type_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model/fake_model_type_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model/model_type_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model/stub_model_type_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model/stub_model_type_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/model_impl/client_tag_based_model_type_processor.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/user_events/user_event_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/user_events/user_event_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync/user_events/user_event_sync_bridge_unittest.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync_sessions/session_sync_bridge.cc [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync_sessions/session_sync_bridge.h [modify] https://crrev.com/5c72faf2490896d21a6d46ef9f25c73684269b1a/components/sync_sessions/session_sync_bridge_unittest.cc
Comment 1 by hs1217....@samsung.com
, Jun 12 2018Status: Assigned (was: Available)