New issue
Advanced search Search tips

Issue 851844 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app: Define a label to toggle visibility of hidden Android folders.

Project Member Reported by fukino@chromium.org, Jun 12 2018

Issue description

Under "Play Files" volume, we have only whitelisted folders by default.
As seen in the attached screenshot, we have a toggle option to show hidden folders in the gear menu.

The label for the toggle option is temporary.
Weifang, could you define the string for the toggle option?
 
Screenshot 2018-06-12 at 4.13.22 PM.png
185 KB View Download

Comment 1 by fukino@chromium.org, Jun 19 2018

Weifang, is it possible to finalize the string before feature freeze (6/22)?
Hi fukino-san! Sorry for the delay. Checked with our UX writer today and we should label the toggle as "Show all Play folders".

Comment 3 by fukino@chromium.org, Jun 20 2018

Thanks Weifang! I'll change the label before feature freeze.

Comment 4 by fukino@chromium.org, Jun 22 2018

Cc: -fukino@chromium.org weifangsun@chromium.org
Owner: fukino@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b56a0d4e3698b7db79dcce93a74051d995c855b3

commit b56a0d4e3698b7db79dcce93a74051d995c855b3
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri Jun 22 06:48:19 2018

Internationalize a menu item label to show all Android files.

Bug:  851844 
Test: The new label is manually checked.
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I879ea833ab2da5dc5b6293cfbb06e3fa589d408b
Reviewed-on: https://chromium-review.googlesource.com/1111494
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569545}
[modify] https://crrev.com/b56a0d4e3698b7db79dcce93a74051d995c855b3/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/b56a0d4e3698b7db79dcce93a74051d995c855b3/chrome/app/chromeos_strings_grdp/IDS_FILE_BROWSER_SHOW_ALL_ANDROID_FOLDERS_OPTION.png.sha1
[modify] https://crrev.com/b56a0d4e3698b7db79dcce93a74051d995c855b3/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/b56a0d4e3698b7db79dcce93a74051d995c855b3/ui/file_manager/file_manager/main.html

Comment 6 by fukino@chromium.org, Jun 22 2018

Status: Fixed (was: Started)

Sign in to add a comment