New issue
Advanced search Search tips

Issue 851835 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus is lost after pressing tab key in chrome://history/ page.

Reported by vku...@etouch.net, Jun 12 2018 
Chrome Version: 69.0.3455.0 (Official Build)Revision f981d5ba6963015157ac5faa8090cd22bec65a3c-refs/branch-heads/3455@{#1} (32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.12.6,10.13.1,10.13.6) & Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to 2-3 webpages.
(2)Navigate to chrome://history/ , click on checkbox of any entry 
(3)Press ctrl+L such that focus appears in omnibox.
(4)Now press tab key and observe the focus.

Actual: Focus is lost after pressing tab key in chrome://history/ page.

Expected: Focus should be seen on close'X' icon after pressing tab key in chrome://history/ page.

This is a regression issue broken in 'M69' and below is the bisect info
Good Build: 69.0.3451.0(Revision:564769)
Bad Build:  69.0.3452.0(Revision:565143)
Actual_History.mp4
222 KB View Download
Expected_History.mp4
92.6 KB View Download

Comment 1 by vku...@etouch.net, Jun 12 2018

Labels: RegressedIn-69 FoundIn-69 Target-69 hasbisect
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)
Narrow Bisect info: 
You are probably looking for a change made after 564798 (known good), but no later than 564802 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/e2e96f1fd5100ff6ddd7a4c5c9778eb21ed2140d..b9b3a7e867859e1b17015f61e09077bc78eee478?pretty=fuller&n=50

Suspecting: r564801 ?

@calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31414f90a35d99834cbe2c96a95a9abb7012448d

commit 31414f90a35d99834cbe2c96a95a9abb7012448d
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Jun 13 08:50:23 2018

[cr-toolbar-selection-overlay] Hide toolbar when showing overlay.

This CL fixes an issue where the overlay didn't hide the toolbar properly
so it could still be tabbed to, and a corresponding problem where overlay
buttons could be tabbed to when not visible.

Bug:  851835 ,  851864 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1562211745c2373ee64a85936953137f2541ae48
Reviewed-on: https://chromium-review.googlesource.com/1098420
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566763}
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js
[modify] https://crrev.com/31414f90a35d99834cbe2c96a95a9abb7012448d/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 3 by calamity@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment