New issue
Advanced search Search tips

Issue 851831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 846235



Sign in to add a comment

NetS13nServiceWorker: Make ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure pass

Project Member Reported by shimazu@chromium.org, Jun 12 2018

Issue description

It's failing at checking cert existence. We need to propagate the url loader options to MojoAsyncResourceHandler correctly.

-- stack trace --

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x7ff3bc0d803c base::debug::StackTrace::StackTrace()                        
#1 0x000000d02c35 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7ff3b1879030 <unknown>                              
#3 0x7ff3bba99537 net::X509Certificate::EqualsExcludingChain()                                                                                                                                               
#4 0x00000091fc5c content::ServiceWorkerBrowserTest_ResponseFromHTTPSServiceWorkerIsMarkedAsSecure_Test::RunTestOnMainThread()
#5 0x000000d0294e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x000000d9a346 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#7 0x7ff3b9d62f21 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x7ff3ba258355 content::StartupTaskRunner::RunAllTasksNow()
#9 0x7ff3b9d6162c content::BrowserMainLoop::CreateStartupTasks()
#10 0x7ff3b9d65d45 content::BrowserMainRunnerImpl::Initialize()
#11 0x7ff3b9d65ca7 content::BrowserMainRunnerImpl::Initialize() 
#12 0x000000d99b2d ShellBrowserMain()                    
#13 0x000000d4f57d content::ShellMainDelegate::RunProcess()       
#14 0x7ff3ba8256c3 content::RunBrowserProcessMain()       
#15 0x7ff3ba8267c4 content::ContentMainRunnerImpl::Run()                       
#16 0x7ff3b78926bf service_manager::Main()                                                       
#17 0x7ff3ba8245b4 content::ContentMain()
#18 0x000000d024b2 content::BrowserTestBase::SetUp()
#19 0x000000cf7644 content::ContentBrowserTest::SetUp()                                                                                                   
#20 0x000000bf0e1d testing::Test::Run()                                                
#21 0x000000bf1a80 testing::TestInfo::Run()          
#22 0x000000bf1f97 testing::TestCase::Run()                                                                                                                  
#23 0x000000bfd987 testing::internal::UnitTestImpl::RunAllTests()
#24 0x000000bfd4fd testing::UnitTest::Run()
#25 0x000000d3d751 base::TestSuite::Run()                                 
#26 0x000000cfb3d7 content::ContentTestLauncherDelegate::RunTestSuite()                                                                                                                                                                                                                  
#27 0x000000d22ff0 content::LaunchTests()
#28 0x000000cfb390 main
#29 0x7ff3b18662b1 __libc_start_main
#30 0x0000004bf02a _start
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6185fc9e4b7ae4e7433008bcc9e6c9a8f2c1887

commit c6185fc9e4b7ae4e7433008bcc9e6c9a8f2c1887
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jun 12 14:47:00 2018

Plumb URLLoadOptions to MojoAsyncResourceHandler

Currently we pass kURLLoadOptionNone when creating MojoAsyncResourceHandler
regardless of options passed at OnRequestResourceWithMojo(). This CL is to plumb
the options to MojoAsyncResourceHandler to get correct information. For example,
when loading a service worker's main script, SSLInfo should be attached with the
response.

Bug:  851831 
Change-Id: I34b6bea644ef34b0b2b0dfd856b8541e3aa1368c
Reviewed-on: https://chromium-review.googlesource.com/1096731
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566422}
[modify] https://crrev.com/c6185fc9e4b7ae4e7433008bcc9e6c9a8f2c1887/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/c6185fc9e4b7ae4e7433008bcc9e6c9a8f2c1887/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/c6185fc9e4b7ae4e7433008bcc9e6c9a8f2c1887/content/browser/loader/resource_dispatcher_host_impl.h

Comment 2 by dxie@google.com, Jun 12 2018

Labels: Hotlist-KnownIssue
Status: Fixed (was: Started)

Sign in to add a comment