New issue
Advanced search Search tips

Issue 851823 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 841631



Sign in to add a comment

Remove deprecated use of NSApplication beginSheet:modalForWindow:modalDelegate:didEndSelector:contextInfo:

Project Member Reported by tapted@chromium.org, Jun 12 2018

Issue description

NSApplication beginSheet was deprecated in 10.10 and will probably block bumping the deployment target
beginSheet:completionHandler: was introduced in 10.9.

https://developer.apple.com/documentation/appkit/nsapplication/1428505-beginsheet?language=objc  

Says
"""
Starts a document modal session.

Deprecated

Use the beginSheet:completionHandler: method of NSWindow instead.
"""


This is still used in MacViews' BridgedNativeWidget, which is a good candidate to migrate. Other client code will likely just get deleted Soon.
 

Comment 1 by tapted@chromium.org, Jun 12 2018

Status: Available (was: Unconfirmed)

Comment 2 by tapted@chromium.org, Jun 13 2018

ooh also -[NSApplication endSheet:] is deprecated -- -[NSWindow endSheet:] should be used instead.
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
Mass UI Triage.

Sign in to add a comment