[Findit] Flake Analyzer - Cannot rerun analysis |
||||
Issue descriptionAnalyses on tryserver.* cannot be rerun due to mismatch in master_name/builder_name etc. Should use original_* instead
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/bcee28cb68f095c36fb0c948907abe17116ca8b5 commit bcee28cb68f095c36fb0c948907abe17116ca8b5 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Tue Jun 12 17:29:09 2018 [Findit] Flake Analyzer - Fix rerun for tryserver.* When triggering reruns, original_* fields should be used to avoid mismatch when finding build steps to merge into the existing request created by the original analysis. Bug: 851777 Change-Id: Ife38d09f562a0921e70bdb255c451e9d8bcfc3b4 Reviewed-on: https://chromium-review.googlesource.com/1096550 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/bcee28cb68f095c36fb0c948907abe17116ca8b5/appengine/findit/handlers/flake/check_flake.py [modify] https://crrev.com/bcee28cb68f095c36fb0c948907abe17116ca8b5/appengine/findit/handlers/flake/test/check_flake_test.py
,
Jun 12 2018
,
Jun 13 2018
The fix is incomplete, as the resulting analysis needs to be referenced using the non original_* fields
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/aa55ce02f2fc5c86b58bb01ad1ca317ac5233aed commit aa55ce02f2fc5c86b58bb01ad1ca317ac5233aed Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Jun 15 21:03:57 2018 [Findit] Flake Analyzer - Fixing rerun of cq flakes Build steps should reference analysis.original_* fields, while the analyses themselves should be referenced using the regular master_name, builder_name, etc. fields. Bug: 851777 Change-Id: I108e2f18352ce3ece85b1a6eb51a66567c774f83 Reviewed-on: https://chromium-review.googlesource.com/1098309 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/aa55ce02f2fc5c86b58bb01ad1ca317ac5233aed/appengine/findit/handlers/flake/check_flake.py [modify] https://crrev.com/aa55ce02f2fc5c86b58bb01ad1ca317ac5233aed/appengine/findit/handlers/flake/test/check_flake_test.py [modify] https://crrev.com/aa55ce02f2fc5c86b58bb01ad1ca317ac5233aed/appengine/findit/waterfall/flake/flake_analysis_service.py
,
Jun 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lijeffrey@chromium.org
, Jun 12 2018