[Picture-in-Picture] Able to create multiple PiP windows |
||
Issue descriptionChrome Version: 69.0.3456.0 OS: Linux What steps will reproduce the problem? (1) Launch PiP window from one tab (2) Create new tab in same browser, then separate that tab to create another window. (3) Launch PiP window from second tab. First PiP window should be destroyed for second one to be created. Instead, the first remains active and the user has two PiP windows.
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abd8e1e73eafee7c8d16e47a830733af2fcad8bc commit abd8e1e73eafee7c8d16e47a830733af2fcad8bc Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Jun 22 14:33:17 2018 Picture-in-Picture: use a singleton to manage open windows. This should enforce one Picture-in-Picture window per Chrome instance. It should also solve a few edge cases where a WebContents was closed and the associated PictureInPictureWindowController was still around and later used. Note that we may be able to better architecture this. It is a naive design that simply move the code out of browser.cc. Bug: 851775 Change-Id: Ib26ffadd1035f58ffa9bcf475070a469361c9e6e Reviewed-on: https://chromium-review.googlesource.com/1107304 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569613} [modify] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/BUILD.gn [modify] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [add] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc [add] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/picture_in_picture/picture_in_picture_window_manager.h [modify] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/ui/browser.cc [modify] https://crrev.com/abd8e1e73eafee7c8d16e47a830733af2fcad8bc/chrome/browser/ui/browser.h
,
Jun 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Jun 22 2018Owner: mlamouri@chromium.org
Status: Started (was: Untriaged)