Add features to chrome://power |
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36 Steps to reproduce the problem: Currently, chrome://power just has idle and frequency state information as well as system-wide battery information. It would be nice if chrome://power had more detailed and fine-grained information about the power consumption of apps at a process level. What is the expected behavior? What went wrong? chrome://power should have process-granularity information. Did this work before? N/A Chrome version: 69.0.3456.0 Channel: stable OS Version: Flash Version: 30.0.0.113
,
Jun 29 2018
nathreya@ is working on this but for some reason 'project member' status isn't enabled yet so I can't assign. Assigning to Abhishek for time being.
,
Jun 29 2018
Nikhil, mind joining the two groups described at http://g/chromeos-chatty-eng/0lv6jt5_sW0 so bugs can be assigned to you? (Same thing on issue 850807 .)
,
Jun 29 2018
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f0eb94db1b41c9eae1bbd1da386bdefa978343d commit 7f0eb94db1b41c9eae1bbd1da386bdefa978343d Author: Nikhil Athreya <nathreya@google.com> Date: Mon Jul 02 22:34:03 2018 power: Add GetKeyboardBrightnessPercent Adds a GetKeyboardBrightnessPercent method to the PowerManagerClient interface. This method was added in order to track keyboard energy consumption over time so that chrome://power could approximate power usage of other devices over time. keyboard brightness change as you increase and decrease your keyboard brightness. BUG: crbug.com/851767 TEST: Call this method inside Chrome on a Chrome OS device and see the Change-Id: I35323708da1e0bcc9b4549b85ad6e2d8ad215af5 Reviewed-on: https://chromium-review.googlesource.com/1120839 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Nikhil Athreya <nathreya@google.com> Cr-Commit-Position: refs/heads/master@{#572025} [modify] https://crrev.com/7f0eb94db1b41c9eae1bbd1da386bdefa978343d/chromeos/dbus/fake_power_manager_client.cc [modify] https://crrev.com/7f0eb94db1b41c9eae1bbd1da386bdefa978343d/chromeos/dbus/fake_power_manager_client.h [modify] https://crrev.com/7f0eb94db1b41c9eae1bbd1da386bdefa978343d/chromeos/dbus/power_manager_client.cc [modify] https://crrev.com/7f0eb94db1b41c9eae1bbd1da386bdefa978343d/chromeos/dbus/power_manager_client.h
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f54a8a651c9648cff86cf8fd89b85d41229f70f commit 2f54a8a651c9648cff86cf8fd89b85d41229f70f Author: Nikhil Athreya <nathreya@google.com> Date: Tue Jul 31 02:32:10 2018 power: Add process data collection This change is part of the update to the chrome://power page. This commit adds a new process data collector that will eventually be integrated into chrome://power. Currently, for each process, it aggregates what type of process and it approximates the average CPU usage of that process across its lifetime for all processes in the system. This will eventually be used as part of a battery usage approximation metric. BUG: crbug.com/851767 TEST: Run unittests provided in the commit. Change-Id: If63289a827b530bca808626f9133c52276dc5d6f Reviewed-on: https://chromium-review.googlesource.com/1096408 Commit-Queue: Nikhil Athreya <nathreya@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#579287} [modify] https://crrev.com/2f54a8a651c9648cff86cf8fd89b85d41229f70f/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/2f54a8a651c9648cff86cf8fd89b85d41229f70f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [add] https://crrev.com/2f54a8a651c9648cff86cf8fd89b85d41229f70f/chrome/browser/chromeos/power/process_data_collector.cc [add] https://crrev.com/2f54a8a651c9648cff86cf8fd89b85d41229f70f/chrome/browser/chromeos/power/process_data_collector.h [add] https://crrev.com/2f54a8a651c9648cff86cf8fd89b85d41229f70f/chrome/browser/chromeos/power/process_data_collector_unittest.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0896c26d6c44bbe899b3bafdd65ba8ada33d908 commit a0896c26d6c44bbe899b3bafdd65ba8ada33d908 Author: Nikhil Athreya <nathreya@google.com> Date: Thu Aug 02 04:24:01 2018 power: Pass process usage data from c++ to js Recognizes a request for process usage data from ProcessDataCollector when an IPC message from the render (invoked from Javascript) is invoked and passes the information in the ProcessDataCollector::ProcessUsageData struct's to the JS code. requestProcessUsageData from the JS console. BUG: crbug.com/851767 TEST: On a Chrome OS device, go to chrome://power and call Change-Id: Ief597fd97032254c3675371d6a0419cdea0e49f1 Reviewed-on: https://chromium-review.googlesource.com/1157133 Commit-Queue: Nikhil Athreya <nathreya@google.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#580061} [modify] https://crrev.com/a0896c26d6c44bbe899b3bafdd65ba8ada33d908/chrome/browser/chromeos/power/process_data_collector.h [modify] https://crrev.com/a0896c26d6c44bbe899b3bafdd65ba8ada33d908/chrome/browser/resources/chromeos/power.html [modify] https://crrev.com/a0896c26d6c44bbe899b3bafdd65ba8ada33d908/chrome/browser/resources/chromeos/power.js [modify] https://crrev.com/a0896c26d6c44bbe899b3bafdd65ba8ada33d908/chrome/browser/ui/webui/chromeos/power_ui.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, Jun 15 2018