New issue
Advanced search Search tips

Issue 851749 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Jun 2018
Cc:
vmi...@chromium.org
ericrk@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 851748



Sign in to add a comment

VulkanSurface no longer setting device_queue_

Project Member Reported by cblume@chromium.org, Jun 11 2018 
In a CL I landed I accidentally removed a line which set device_queue_ inside VulkanSurface. When it was later dereferenced we would hit and null pointer dereference exception.

Restore this code.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9cfd68f3a8db1f4c99902eb1251e90d0772e20

commit eb9cfd68f3a8db1f4c99902eb1251e90d0772e20
Author: Chris Blume <cblume@chromium.org>
Date: Tue Jun 12 21:16:53 2018

Set VulkanSurface's device_queue_

In a previous CL I accidentally removed the lines which set
device_queue_. As a result, dereferencing it would cause a null pointer
exception.

This patch sets device_queue_ again and fixes our Vulkan tests.

BUG= 851749 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I69b5c8038e6b02e42a462bbaabdb24c238d184b0
Reviewed-on: https://chromium-review.googlesource.com/1096439
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566571}
[modify] https://crrev.com/eb9cfd68f3a8db1f4c99902eb1251e90d0772e20/gpu/vulkan/vulkan_surface.cc

Comment 2 by cblume@chromium.org, Jun 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment