Android horizontal tab switcher gets messed up if incognito toggle is pressed during scroll |
||||||
Issue descriptionChrome Version: 69.0.3455 (Official Build) canary (32-bit) OS: Android 8.1.0 The Android horizontal tab switcher gets messed up if the incognito toggle button is tapped while the tabs are scrolling. This is because the animation works by sliding the centered tab and the one on either side off-screen, and then sliding them back on if incognito mode is toggled again. If the tabs are scrolling, the centered tab can change between the two animations, which means we can fail to slide the off-screen tabs back to the right place. The fix is to stop scrolling before we run the switch away animation.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/750082e000c568fae19099fd0544aed89c60a41f commit 750082e000c568fae19099fd0544aed89c60a41f Author: Ryan Landay <rlanday@chromium.org> Date: Tue Jun 12 16:50:13 2018 Fix bug toggling incognito mode while scrolling in Android tab switcher The Android horizontal tab switcher can get messed up if the incognito toggle button is tapped while the tabs are scrolling. This is because the animation works by sliding the centered tab and the one on either side off-screen, and then sliding them back on if incognito mode is toggled again. If the tabs are scrolling, the centered tab can change between the two animations, which means we can fail to slide the off-screen tabs back to the right place. This CL fixes the issue by making sure we stop scrolling before we run the switch away animation. Bug: 851745 Change-Id: I686f79317870f8160a044996a5fcd33186966a34 Reviewed-on: https://chromium-review.googlesource.com/1096447 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#566466} [modify] https://crrev.com/750082e000c568fae19099fd0544aed89c60a41f/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java
,
Jun 12 2018
,
Jun 12 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2018
Please verify the fix in canary
,
Jun 14 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/843af6eda3f0b64c64eca7ed639bc22178f6125d commit 843af6eda3f0b64c64eca7ed639bc22178f6125d Author: Ryan Landay <rlanday@chromium.org> Date: Thu Jun 14 21:07:11 2018 Fix bug toggling incognito mode while scrolling in Android tab switcher The Android horizontal tab switcher can get messed up if the incognito toggle button is tapped while the tabs are scrolling. This is because the animation works by sliding the centered tab and the one on either side off-screen, and then sliding them back on if incognito mode is toggled again. If the tabs are scrolling, the centered tab can change between the two animations, which means we can fail to slide the off-screen tabs back to the right place. This CL fixes the issue by making sure we stop scrolling before we run the switch away animation. Bug: 851745 Change-Id: I686f79317870f8160a044996a5fcd33186966a34 Reviewed-on: https://chromium-review.googlesource.com/1096447 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566466}(cherry picked from commit 750082e000c568fae19099fd0544aed89c60a41f) Reviewed-on: https://chromium-review.googlesource.com/1101739 Reviewed-by: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#366} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/843af6eda3f0b64c64eca7ed639bc22178f6125d/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java
,
Jun 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rlanday@chromium.org
, Jun 11 20183.5 MB
3.5 MB View Download