New issue
Advanced search Search tips

Issue 851744 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 751756



Sign in to add a comment

Enable Gerrit CLA for franky

Project Member Reported by tandrii@chromium.org, Jun 11 2018

Issue description

Repo: https://chromium.googlesource.com/chromium/src/tools/franky.git

Why? Gerrit is better enforce than CQ.
More why? see  issue 796383 

Caveat: any robot accounts that bypassed CQ need to be whitelisted
https://g3doc.corp.google.com/company/teams/opensource/cla/index.md?cl=head#robots


Plan of action:
(0) You ACK this and allow me to proceed.
(1) I enable CLA check in Gerrit for you.
(2) you create and land CL to remove "sign_cla {}" from your project cq.cfg.
 
Cc: bjoyce@chromium.org
+bjoyce@, since I no longer support Franky. But on the surface this LGTM. I don't believe Franky uses any robots other than CQ to post or commit CLs.
Owner: bjoyce@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by bjoyce@chromium.org, Jun 12 2018

HI, enable cla and I can remove the sing_cla{} from franky/./infra/config/cq.cfg
Done! It was actually enabled all along because you inherit from Chromium :)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/tools/franky/+/9244087121d23de59c69b353317a6983a630e560

commit 9244087121d23de59c69b353317a6983a630e560
Author: Ben Joyce <bjoyce@google.com>
Date: Tue Jun 12 22:30:10 2018

Remove signed_cla for gerrit CLA.

Bug:851744
Change-Id: I04074c16d19af5063a0f06a567c67ee4310fcf17
Reviewed-on: https://chromium-review.googlesource.com/1097994
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Benjamin Joyce <bjoyce@google.com>

[modify] https://crrev.com/9244087121d23de59c69b353317a6983a630e560/infra/config/cq.cfg

Status: Fixed (was: Assigned)
Thank you for cooperation.

Sign in to add a comment