New issue
Advanced search Search tips

Issue 851733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Fuchsia: Remove dependencies on media_client lib

Project Member Reported by sergeyu@chromium.org, Jun 11 2018

Issue description

On Fuchsia chrome currently depends on media_client library for Audio IO. that library is deprecated. Instead chrome should use AudioRenderer and AudioCapturer interfaces.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cec6c171f9f635121dd5594cc6832280cf79c947

commit cec6c171f9f635121dd5594cc6832280cf79c947
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jun 14 19:49:00 2018

Fuchsia: Move AudioOutputStreamFuchsia to AudioRenderer2.

Previously AudioOutputStreamFuchsia was using media_client library,
which is deprecated now. Update //media to use AudioRenderer2 FIDL
interface directly.

Bug:  851733 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I356a0ae08798c2eb62d4cb42355aff4c47fbb360
Reviewed-on: https://chromium-review.googlesource.com/1096414
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567376}
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/BUILD.gn
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/audio_output_unittest.cc
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/audio_thread_impl.cc
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/fuchsia/audio_manager_fuchsia.cc
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/fuchsia/audio_manager_fuchsia.h
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/fuchsia/audio_output_stream_fuchsia.cc
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/media/audio/fuchsia/audio_output_stream_fuchsia.h
[modify] https://crrev.com/cec6c171f9f635121dd5594cc6832280cf79c947/third_party/fuchsia-sdk/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08410d5699d3b709c775337c15e2c9e594c50aed

commit 08410d5699d3b709c775337c15e2c9e594c50aed
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Jun 18 20:59:14 2018

Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2.

Previously MixerOutputStreamFuchsia was using media_client library,
which is deprecated now. Update it to use AudioRenderer2 FIDL interface
directly.

Bug:  851733 
Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e
Reviewed-on: https://chromium-review.googlesource.com/1100376
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568159}
[modify] https://crrev.com/08410d5699d3b709c775337c15e2c9e594c50aed/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/08410d5699d3b709c775337c15e2c9e594c50aed/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
[modify] https://crrev.com/08410d5699d3b709c775337c15e2c9e594c50aed/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
[modify] https://crrev.com/08410d5699d3b709c775337c15e2c9e594c50aed/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia_unittest.cc
[modify] https://crrev.com/08410d5699d3b709c775337c15e2c9e594c50aed/chromecast/media/cma/backend/stream_mixer.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c

commit 1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c
Author: Steven Holte <holte@chromium.org>
Date: Mon Jun 18 23:12:31 2018

Revert "Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2."

This reverts commit 08410d5699d3b709c775337c15e2c9e594c50aed.

Reason for revert: 
This appears to be causing build failures due to a DEPS issue:
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943347677136985328%2F%2B%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

BUG= 853968 

Original change's description:
> Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2.
> 
> Previously MixerOutputStreamFuchsia was using media_client library,
> which is deprecated now. Update it to use AudioRenderer2 FIDL interface
> directly.
> 
> Bug:  851733 
> Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e
> Reviewed-on: https://chromium-review.googlesource.com/1100376
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568159}

TBR=wez@chromium.org,sergeyu@chromium.org,kmackay@chromium.org

Change-Id: I9b5b2262d8ddc2edb706fb6fbec3d1fdc6d19563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851733 
Reviewed-on: https://chromium-review.googlesource.com/1105320
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568219}
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia_unittest.cc
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/stream_mixer.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652d14876c8e07fde222031f44fc506bd6b26547

commit 652d14876c8e07fde222031f44fc506bd6b26547
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jun 19 00:56:13 2018

Reland "Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2."

This is a reland of 08410d5699d3b709c775337c15e2c9e594c50aed
TBR=kmackay@chromium.org

Original change's description:
> Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2.
>
> Previously MixerOutputStreamFuchsia was using media_client library,
> which is deprecated now. Update it to use AudioRenderer2 FIDL interface
> directly.
>
> Bug:  851733 
> Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e
> Reviewed-on: https://chromium-review.googlesource.com/1100376
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568159}

Bug:  851733 
Change-Id: Id61c6d2cda42f6b6696bbb4d7649b334fd7d7d41
Reviewed-on: https://chromium-review.googlesource.com/1105138
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568270}
[modify] https://crrev.com/652d14876c8e07fde222031f44fc506bd6b26547/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/652d14876c8e07fde222031f44fc506bd6b26547/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
[modify] https://crrev.com/652d14876c8e07fde222031f44fc506bd6b26547/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
[modify] https://crrev.com/652d14876c8e07fde222031f44fc506bd6b26547/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia_unittest.cc
[modify] https://crrev.com/652d14876c8e07fde222031f44fc506bd6b26547/chromecast/media/cma/backend/stream_mixer.cc

Sign in to add a comment