New issue
Advanced search Search tips

Issue 851724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

UMA Sampling Profiler feature updates

Project Member Reported by wittman@chromium.org, Jun 11 2018

Issue description

Reviewing the features used by the UMA Sampling Profiler Predator support I found a few issues:

1. The TopFrameIndex feature doesn't operate as expected since the feature expects the frame indices to increment from 0 from leaf up. The UMA Sampling Profiler currently sets the indices to the frame depth from root down, and excludes indices above the  regression subtree root. I believe the practical effect is that this feature will evaluate to 0 on nearly all stacks because most regression subtrees do not have indices with the range of [0, 7] which are the min and max indices used by the rule.

Independent of this, we probably don't want to use this feature anyway because it does the opposite of what we'd want, which would be to provide a slight bias towards matches closer to the subtree root. We can remove it for now and later consider reintroducing a different rule creating a preference for nodes closer to the subtree root if this seems like it would be useful.

2. The NumberOfTouchedFiles feature also is probably not useful for the UMA Sampling Profiler. CLs that touch many files are as likely as smaller CLs to introduce changes that we want to detect, particularly refactoring changes that change function signatures. In that case it's important to detect that the removal of the old signature and the addition of the new signature were introduced by the same CL. So we should remove this feature also.

3. The TouchCrashedComponentFeature is specified but no weight is provided. I don't expect this feature to be very useful so think we can remove it as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d58bac93c9048c4f2d2846dc3823c5b2dda8fb65

commit d58bac93c9048c4f2d2846dc3823c5b2dda8fb65
Author: Mike Wittman <wittman@chromium.org>
Date: Wed Jun 20 23:15:23 2018

Remove undesirable features for UMA Sampling Profiler

These features either have no impact or have a negative impact on the
regression detection.

Bug:  851724 
Change-Id: I1fb09acd962bab0c014831453dac25e6bd5b58cf
Reviewed-on: https://chromium-review.googlesource.com/1099761
Reviewed-by: Sharu Jiang <katesonia@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>

[modify] https://crrev.com/d58bac93c9048c4f2d2846dc3823c5b2dda8fb65/appengine/predator/app/common/predator_for_uma_sampling_profiler.py

Status: Fixed (was: Assigned)

Sign in to add a comment