[ChromeDriver] SessionHandlingTests {testGetSessions,testQuitASessionMoreThanOnce} Failing on Mac 10.10 Bot |
|||
Issue descriptionThis is the first build with the failure. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32955 (ignore the other four chromedriver_py test failures; that's a separate issue; see https://chromium-review.googlesource.com/c/chromium/src/+/1095674) Those two tests have been failing consistently since then. I don't see anything in the blame list that seems like a cause. ====================================================================== ERROR: testGetSessions (__main__.SessionHandlingTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../../chrome/test/chromedriver/test/run_py_tests.py", line 2583, in testGetSessions response = driver2.GetSessions() File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 343, in GetSessions return self.ExecuteCommand(Command.GET_SESSIONS) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 298, in ExecuteCommand response = self._ExecuteCommand(command, params) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 288, in _ExecuteCommand response = self._executor.Execute(command, params) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/command_executor.py", line 197, in Execute response = self._http_client.getresponse() File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 1121, in getresponse response.begin() File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 438, in begin version, status, reason = self._read_status() File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 402, in _read_status raise BadStatusLine(line) BadStatusLine: '' ====================================================================== ERROR: testQuitASessionMoreThanOnce (__main__.SessionHandlingTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../../chrome/test/chromedriver/test/run_py_tests.py", line 2573, in testQuitASessionMoreThanOnce driver = self.CreateDriver() File "../../chrome/test/chromedriver/test/run_py_tests.py", line 294, in CreateDriver **kwargs) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 237, in __init__ response = self._ExecuteCommand(Command.NEW_SESSION, params) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 288, in _ExecuteCommand response = self._executor.Execute(command, params) File "/b/s/w/ir/chrome/test/chromedriver/test/../client/command_executor.py", line 196, in Execute self._http_client.request(command[0], '/'.join(substituted_parts), body) File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 1042, in request self._send_request(method, url, body, headers) File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 1082, in _send_request self.endheaders(body) File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 1038, in endheaders self._send_output(message_body) File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 882, in _send_output self.send(msg) File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 844, in send self.connect() File "/b/s/w/ir/.swarming_module/lib/python2.7/httplib.py", line 821, in connect self.timeout, self.source_address) File "/b/s/w/ir/.swarming_module/lib/python2.7/socket.py", line 575, in create_connection raise err Incidentally, the flakiness dashboard is confusing. It makes it look like they've been failing consistently since they were enabled. I don't think that's the case. (In the runs before the run linked above, those tests were run and succeeded.) https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chromedriver_py_tests&tests=testGetSessions%2CtestQuitASessionMoreThanOnce
,
Jun 11 2018
I LGTM'd it. Thanks for sheriffing!
,
Jun 11 2018
FYI this is a test run where Sessions worked on that bot: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944236213340107376%2F%2B%2Fsteps%2Fchromedriver_py_tests_on_Mac-10.10%2F0%2Fstdout I think that what's going on is that the other failures from https://chromium-review.googlesource.com/c/chromium/src/+/1095674 are causing leftover sessions to be hanging around so then the two Sessions tests are. I need to confirm this though.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd3b2af5cc828d6aa8fa2f1d48a290fb99b4164a commit cd3b2af5cc828d6aa8fa2f1d48a290fb99b4164a Author: Mark Pearson <mpearson@chromium.org> Date: Mon Jun 11 23:35:29 2018 ChromeDriver - Disable Two SessionHandlingTests because they fail consistently on Mac 10.10. There are no obvious culprits. This is to make the build turn green again, i.e., this redness won't cover up other redness. TBR=johnchen NOTRY=true Bug: 851721 Change-Id: I80a5662ec89a77fb2ebbed765c12a0a64674a700 Reviewed-on: https://chromium-review.googlesource.com/1096402 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#566202} [modify] https://crrev.com/cd3b2af5cc828d6aa8fa2f1d48a290fb99b4164a/chrome/test/chromedriver/test/run_py_tests.py
,
Jun 11 2018
FYI, tnijssen@ is workingon a fix (https://chromium-review.googlesource.com/c/chromium/src/+/1095545) for that other issue, which she may land soon. You may want (or not want) to coordinate your possible ideas with landing of that fix.
,
Jun 11 2018
Optimistically removing from sheriff queue.
,
Jun 26 2018
The failures of the two SessionHandlingTests were caused by r565799, which had already been reverted and then fixed. Thus we can re-enable these two tests. More details: These two tests were originally enabled by r565148, and was first included in build 32888 of Mac 10.10 Tests bot. Bot history shows no chromedriver_py_tests failures between builds 32888 and 32953. These two tests started failing in every builds since 32954, when r565799 landed. The failures continued until r565799 was reverted by r566163, and no more failures since build 33030. These two tests were later disabled by r566202, first in build 33031, but they had already stopped failing since r565799 was reverted.
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a599f10a42b637d6dbf03e805894e59fc4d5f79f commit a599f10a42b637d6dbf03e805894e59fc4d5f79f Author: John Chen <johnchen@chromium.org> Date: Tue Jun 26 17:05:36 2018 [ChromeDriver] Re-enable SessionHandlingTests for integration The condition causing these two tests to fail no longer exists, thus re-enabling them. Bug: 851721 Change-Id: I4a21c41fbe35af45c45b2e215ae0ed54495004ad Reviewed-on: https://chromium-review.googlesource.com/1115209 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570432} [modify] https://crrev.com/a599f10a42b637d6dbf03e805894e59fc4d5f79f/chrome/test/chromedriver/test/run_py_tests.py
,
Jun 27 2018
These two tests were re-enabled about a day ago, and no failures in chromedriver_py_tests have been observed on Mac 10.10 bot. Marking the issue as Fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mpear...@chromium.org
, Jun 11 2018