[PaintTouchActionRects] Extend hit test painting to all boxes, not just blocks. |
|||
Issue description[1] put the call to RecordHitTestData in BlockPainter::PaintObject but this should really be somewhere more central such as BoxPainter::PaintBoxDecorationBackgroundWithRect (see comment in RecordHitTestData). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1069699
,
Sep 7
This has pretty much been done by Xida. He added touch action painting for SVG, replaced, etc. I think one remaining subclass of LayoutBox not covered is LayoutTableBoxComponent (i.e., TablePainter). We should add a test of table rows with touch action.
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9 commit 82ef3030f829530ac4ac9ff7c34798c2d2ce84f9 Author: Xida Chen <xidachen@chromium.org> Date: Sat Sep 08 00:34:52 2018 [PTAR] Add RecordHitTestData for TablePainter This CL records touch action rects for TablePainter. A layout test is added to ensure its correctness. Bug: 851674 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic82e47898ed2b1bf97955dc7fffcf86d9eb7c7e3 Reviewed-on: https://chromium-review.googlesource.com/1213535 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589737} [modify] https://crrev.com/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-table-expected.txt [add] https://crrev.com/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-table.html [modify] https://crrev.com/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9/third_party/blink/renderer/core/paint/table_painter.cc [modify] https://crrev.com/82ef3030f829530ac4ac9ff7c34798c2d2ce84f9/third_party/blink/renderer/core/paint/table_painter.h
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/582cdb5bad94d60f02530a20ab65706c6f4ed66b commit 582cdb5bad94d60f02530a20ab65706c6f4ed66b Author: Xida Chen <xidachen@chromium.org> Date: Tue Sep 11 01:32:03 2018 [PTAR] Add RecordHitTestData for TableRowPainter This CL records touch action rects for TableRowPainter. A layout test case is added to ensure the correctness. Bug: 851674 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3280aaf9c72dda6a75eed5d5ad85b60045c377f7 Reviewed-on: https://chromium-review.googlesource.com/1216706 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590164} [modify] https://crrev.com/582cdb5bad94d60f02530a20ab65706c6f4ed66b/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-table-expected.txt [modify] https://crrev.com/582cdb5bad94d60f02530a20ab65706c6f4ed66b/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-table.html [modify] https://crrev.com/582cdb5bad94d60f02530a20ab65706c6f4ed66b/third_party/blink/renderer/core/paint/table_row_painter.cc [modify] https://crrev.com/582cdb5bad94d60f02530a20ab65706c6f4ed66b/third_party/blink/renderer/core/paint/table_row_painter.h
,
Sep 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benhenry@chromium.org
, Aug 2