[standalones] assets are not on-demand updated when opening Chrome |
|||||||||
Issue descriptionWhen starting Chrome on a standalone the assets component doesn't get updated immediately and, as a result, we always show the fallback in the first six minutes. Fix this.
,
Jun 11 2018
Issue seems to be a race. We try to update the component before we register it.
,
Jun 12 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d70171808d3e03880f974d0878eb62fd82b7fad commit 9d70171808d3e03880f974d0878eb62fd82b7fad Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Jun 14 15:29:12 2018 [vr] Make sure to ondemand update assets component when entering VR Previously, there was a race condition. The ondemand update could be requested before the component was registered. Bug: 851666 Change-Id: I5d2162a87748f93bdf902f78c8cbe63292d65201 Reviewed-on: https://chromium-review.googlesource.com/1097705 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#567275} [modify] https://crrev.com/9d70171808d3e03880f974d0878eb62fd82b7fad/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/9d70171808d3e03880f974d0878eb62fd82b7fad/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/9d70171808d3e03880f974d0878eb62fd82b7fad/chrome/browser/component_updater/vr_assets_component_installer.h
,
Jun 14 2018
David, FYI. On standalones you shouldn't have to wait 6 mins until the assets are installed anymore. They should either be available from the start or the next time you re-open Chrome.
,
Jun 14 2018
Re-opening since I want to merge that back to M-68.
,
Jun 18 2018
Fix has been in Canary since a few days and works.
,
Jun 18 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b324a512310d4f042062ab730ce8bacf4d893258 commit b324a512310d4f042062ab730ce8bacf4d893258 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Jun 19 21:37:48 2018 [vr] Make sure to ondemand update assets component when entering VR Previously, there was a race condition. The ondemand update could be requested before the component was registered. Bug: 851666 Change-Id: I5d2162a87748f93bdf902f78c8cbe63292d65201 Reviewed-on: https://chromium-review.googlesource.com/1097705 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567275}(cherry picked from commit 9d70171808d3e03880f974d0878eb62fd82b7fad) Reviewed-on: https://chromium-review.googlesource.com/1106939 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#454} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/b324a512310d4f042062ab730ce8bacf4d893258/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/b324a512310d4f042062ab730ce8bacf4d893258/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/b324a512310d4f042062ab730ce8bacf4d893258/chrome/browser/component_updater/vr_assets_component_installer.h
,
Jun 19 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tiborg@chromium.org
, Jun 11 2018