New issue
Advanced search Search tips

Issue 851665 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create TableViewImageDataSource

Project Member Reported by thegreenfrog@chromium.org, Jun 11 2018

Issue description

Unify all TableView favicon retrieval protocols to one TableViewImageDataSource protocol
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/750824ee069b059800f0d695fa16e8af92dcb62f

commit 750824ee069b059800f0d695fa16e8af92dcb62f
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Tue Nov 06 18:55:33 2018

[ios] Create TableViewFaviconDataSource

Replaces individual Collection's ImageDataSource. Replaces the ImageDataSource for History and Recent Tabs.

Bug: 851665
Change-Id: I01329b6f0926361d85e48d310dd37c919de47d7f
Reviewed-on: https://chromium-review.googlesource.com/c/1318830
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605763}
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/history/BUILD.gn
[delete] https://crrev.com/1ecb303d3a54356dc070c5a09285039a94435c4c/ios/chrome/browser/ui/history/history_image_data_source.h
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/history/history_mediator.h
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/history/history_mediator.mm
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/history/history_table_view_controller.h
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/recent_tabs/BUILD.gn
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.h
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.mm
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/table_view/BUILD.gn
[rename] https://crrev.com/750824ee069b059800f0d695fa16e8af92dcb62f/ios/chrome/browser/ui/table_view/table_view_favicon_data_source.h

Labels: Hotlist-DesktopUIChecked
***UI Mass Triage ***

If there is no pending work, please feel free to close the issue.

Sign in to add a comment