New issue
Advanced search Search tips

Issue 851660 link

Starred by 1 user
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Jun 2018
Cc:
pdr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 836905



Sign in to add a comment

Support touch action rects when there are window event handlers

Project Member Reported by pdr@chromium.org, Jun 11 2018 
PaintTouchActionRects does not currently create touch action rects if the window has blocking event listeners (see TODO in ScrollingCoordinatorTest.IframeWindowTouchHandler). This bug is for supporting blocking touch event handlers on the window so IframeWindowTouchHandler passes with PaintTouchActionRects enabled.

A potential approach to solving this is to make view_painter.cc draw the background hit test rect, and ensure the LayoutView's IsInsideBlockingTouchEventHandler is invalidated/updated based on the window's event handlers (i.e., when the window event handlers change, invalidate the LayoutView, and when updating the LayoutView, consult the window handlers).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f27f893484e55fe6b7dfcafd386de15cb166cf94

commit f27f893484e55fe6b7dfcafd386de15cb166cf94
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Jun 19 21:28:57 2018

[PaintTouchActionRects] Paint window touch action rects

When the window has a blocking event handler, we need to ensure touch
action rects are painted. This patch paints the window touch action
rects using the LayoutView. In the PrePaint tree walk, blocking touch
event handlers on the window are considered when computing the
LayoutView's effective touch action.

With this change, ScrollingCoordinatorTest.IframeWindowTouchHandler
now passes with PaintTouchActionRects.

Bug:  851660 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux-blink-gen-property-trees
Change-Id: Ifbc9a9c60086ac8c92b6ff4829b3eda0513e3a36
Reviewed-on: https://chromium-review.googlesource.com/1104780
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568607}
[modify] https://crrev.com/f27f893484e55fe6b7dfcafd386de15cb166cf94/third_party/blink/renderer/core/frame/event_handler_registry.cc
[modify] https://crrev.com/f27f893484e55fe6b7dfcafd386de15cb166cf94/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/f27f893484e55fe6b7dfcafd386de15cb166cf94/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc

Comment 2 by pdr@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment