New issue
Advanced search Search tips

Issue 851652 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove use of DownloadId in download code

Project Member Reported by qin...@chromium.org, Jun 11 2018

Issue description

download uses GUID now, downloadId should be deprecated
However, history db and download extension are still using download Ids.
we need to stop using downloadIds in new code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99

commit 901bdca9c1db83cac99cfeb0a5f498eed9a0cb99
Author: Min Qin <qinmin@chromium.org>
Date: Thu Jun 14 23:13:27 2018

remove DownloadId from DownloadCreateInfo

DownloadCreateInfo contains both downloadId and Guid.
Since both can be used to find a download, there is no need to keep
DownloadId.
Passing Guid in DownloadUrlParameters should be enough for resuming a download.

BUG=851652

Change-Id: If7faa264b7e8b413eab932e76b65bfbaebf5e206
Reviewed-on: https://chromium-review.googlesource.com/1095777
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567466}
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/download_create_info.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/download_item_impl_delegate.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/download_item_impl_unittest.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/resource_downloader.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/internal/common/url_download_handler_factory.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/public/common/download_create_info.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/public/common/download_item_impl_delegate.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/components/download/public/common/in_progress_download_manager.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_request_core.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_request_core.h
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_request_core_unittest.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/901bdca9c1db83cac99cfeb0a5f498eed9a0cb99/content/browser/download/url_downloader_factory.cc

Sign in to add a comment