New issue
Advanced search Search tips

Issue 851646 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Add a 1.125 ui scale equivalent for FHD 1.25 DSF devices

Project Member Reported by malaykeshav@chromium.org, Jun 11 2018

Issue description

For FHD 1.25 DSF devices, we supported a ui scale of 1.125 to allow users to have more space on their screen. This was lost in the display zoom world. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2efbcdc641c80311c32b56221389c5d7700af22

commit e2efbcdc641c80311c32b56221389c5d7700af22
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Tue Jun 19 01:33:37 2018

Use static initialized list for zoom levels with DSF

This patch replaces the logic to generate the zoom levels for displays
that have default device scale factor with a static initialized table.

This patch also modifies the table to include beyond native resolution
for FHD 1.25 DSF devices as well as sub FHD devices that have a 1 DSF.

Bug:  851646 
Change-Id: If67d155ce389537b6889e709650e9f9111c62d9c
Component: display zoom, display scaling, display manager
Reviewed-on: https://chromium-review.googlesource.com/1096357
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568285}
[modify] https://crrev.com/e2efbcdc641c80311c32b56221389c5d7700af22/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/e2efbcdc641c80311c32b56221389c5d7700af22/ui/display/manager/display_util.cc
[modify] https://crrev.com/e2efbcdc641c80311c32b56221389c5d7700af22/ui/display/manager/display_util.h
[modify] https://crrev.com/e2efbcdc641c80311c32b56221389c5d7700af22/ui/display/manager/display_utils_unittest.cc

Labels: Merge-Request-68
Status: Fixed (was: Started)
Labels: -Merge-Request-68 Merge-Approved-68
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2b44179d3e478ce0ca2670cbc1f55a31f815a3b

commit b2b44179d3e478ce0ca2670cbc1f55a31f815a3b
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Tue Jun 19 21:08:05 2018

(merge) Use static initialized list for zoom levels with DSF

This patch replaces the logic to generate the zoom levels for displays
that have default device scale factor with a static initialized table.

This patch also modifies the table to include beyond native resolution
for FHD 1.25 DSF devices as well as sub FHD devices that have a 1 DSF.

Bug:  851646 
Change-Id: If67d155ce389537b6889e709650e9f9111c62d9c
Component: display zoom, display scaling, display manager
Reviewed-on: https://chromium-review.googlesource.com/1096357
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568285}(cherry picked from commit e2efbcdc641c80311c32b56221389c5d7700af22)
Reviewed-on: https://chromium-review.googlesource.com/1106937
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#451}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b2b44179d3e478ce0ca2670cbc1f55a31f815a3b/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/b2b44179d3e478ce0ca2670cbc1f55a31f815a3b/ui/display/manager/display_util.cc
[modify] https://crrev.com/b2b44179d3e478ce0ca2670cbc1f55a31f815a3b/ui/display/manager/display_util.h
[modify] https://crrev.com/b2b44179d3e478ce0ca2670cbc1f55a31f815a3b/ui/display/manager/display_utils_unittest.cc

Sign in to add a comment