New issue
Advanced search Search tips

Issue 851643 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Android OOP-D: Fix in-process GPU.

Project Member Reported by ericrk@chromium.org, Jun 11 2018

Issue description

Android OOP-D isn't currently working with in-process GPU (used on low-end devices.
 
Cc: kylec...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8

commit f3d07b7ae4d87eee2f8c80958626391dfc91c5f8
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Jun 27 20:07:55 2018

Fix In-process content browsertests for Viz

Many of our current issues turned out to be due to missing shutdown
logic which caused the GPU thread to shutdown before the compositor,
leading to a number of DCHECKs, and a hang if those were removed.

This change allows the CompositorImpl to tear down before the GPU proc.

Bug:  851643 
Change-Id: Ieb96da9b7132e4ccf8ebf71dc0ee920bfbeb4217
Reviewed-on: https://chromium-review.googlesource.com/1115875
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570880}
[modify] https://crrev.com/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java
[modify] https://crrev.com/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8/content/shell/android/shell_manager.cc
[modify] https://crrev.com/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8/content/shell/android/shell_manager.h
[modify] https://crrev.com/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8/content/shell/browser/shell_android.cc
[modify] https://crrev.com/f3d07b7ae4d87eee2f8c80958626391dfc91c5f8/testing/buildbot/filters/viz.android.content_browsertests.filter

Comment 3 by ericrk@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment