Touch handles are drawn in the wrong place when switching between VR and 2D browsing. |
|||
Issue descriptionOS: Android TTBOMK, the issue is not reproducible ATM. But, it arises when drag support is added to VR. After having selected text in VR, and then going back to 2D browsing, the touch handles are placed incorrectly. It turns out that changes in DIP are not caught by the TouchHandleDrawable.
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/884e1a192542df36c44c32dfb1665e5467793120 commit 884e1a192542df36c44c32dfb1665e5467793120 Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Jun 13 20:50:26 2018 [Android] Making the touch handles aware of DIP changes Instead of caching the DIP scale at creation, query the scale from the view. Bug: 851634 Change-Id: Iaacec8f649fcb0da6aa01ec0859b29f8cf1281b3 Reviewed-on: https://chromium-review.googlesource.com/1099045 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566978} [modify] https://crrev.com/884e1a192542df36c44c32dfb1665e5467793120/content/browser/android/selection/composited_touch_handle_drawable.cc [modify] https://crrev.com/884e1a192542df36c44c32dfb1665e5467793120/content/browser/android/selection/composited_touch_handle_drawable.h [modify] https://crrev.com/884e1a192542df36c44c32dfb1665e5467793120/content/browser/android/selection/selection_popup_controller.cc
,
Jun 13 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by acondor@chromium.org
, Jun 11 2018