[Harmony Cast Dialog] Show origin in the dialog title when presenting |
||||
Issue descriptionAs mentioned in the Presentation API spec [1], we should show the origin (e.g. www.youtube.com) when the user is about to present. [1] https://w3c.github.io/presentation-api/#user-interface-guidelines
,
Jun 12 2018
Do we currently have code to detect when the presentation request is from within an iframe?
,
Aug 2
,
Aug 20
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ca00649033653ab41306f2d5d131bbe3495bd7 commit f4ca00649033653ab41306f2d5d131bbe3495bd7 Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu Oct 04 22:59:11 2018 [Harmony Cast Dialog] Show presentation origin in dialog header When the presentation request is set, use its origin in the dialog header. E.g. "Cast youtube.com" instead of "Cast". If the user selects a non-tab source (desktop or local file), switch to using just "Cast". Bug: 851610 Change-Id: I7c672e458fa82af0182e1d9ed20a7f922e3ad814 Reviewed-on: https://chromium-review.googlesource.com/c/1259618 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#596902} [modify] https://crrev.com/f4ca00649033653ab41306f2d5d131bbe3495bd7/chrome/browser/ui/views/media_router/cast_dialog_view.cc [modify] https://crrev.com/f4ca00649033653ab41306f2d5d131bbe3495bd7/chrome/browser/ui/views/media_router/media_router_views_ui.cc [modify] https://crrev.com/f4ca00649033653ab41306f2d5d131bbe3495bd7/chrome/browser/ui/views/media_router/media_router_views_ui.h [modify] https://crrev.com/f4ca00649033653ab41306f2d5d131bbe3495bd7/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc
,
Oct 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mfo...@chromium.org
, Jun 11 2018