New issue
Advanced search Search tips

Issue 851608 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: 2018-06-14
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 840584
issue 852159



Sign in to add a comment

Move Autoplay logic and UKM collection to AudioContext from BaseAudioContext

Project Member Reported by hongchan@chromium.org, Jun 11 2018 
Autoplay/UKM should tied to AudioContext. In order to do this clean up:

1. enum AutoplayStatus must be moved to AudioContext.
2. All the autoplay related method/properties must be moved:
  - MaybeUnlockUserGesture()
  - IsAllowedToStart()
  - friend class BaseAudioContextAutoplayTest;
  - friend class DISABLED_BaseAudioContextAutoplayTest; (REMOVE)
  - AutoplayPolicy::Type GetAutoplayPolicy() const;
  - bool AreAutoplayRequirementsFulfilled() const;
  - void RecordAutoplayStatus();
  - MaybeRecordStartAttempt()
3. Rewrite BAC constructor.
4. Rewrite unit tests.
  - webaudio/base_audio_context_test.cc

Comment 1 by hongchan@chromium.org, Jun 12 2018

Blocking: 852159
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986

commit 4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986
Author: Hongchan Choi <hongchan@chromium.org>
Date: Thu Jun 14 01:40:37 2018

Move Autoplay-related code from BaseAudioContext to AudioContext

This CL splits the Autoplay-related code from BAC to AC. It simply
changes the code location without changing logic.

Note that the code around resume() promise resolvers has not been
modified in this CL. The code is not directly related to the auto
play and it needs a bit of rewriting.

Bug:  851608 
Test: AudioContextAutoplayTest
Change-Id: I2e0b2b10fc56e86e4724635aba0fe452c73c54da
Reviewed-on: https://chromium-review.googlesource.com/1097988
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567082}
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/audio_context.h
[rename] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/audio_context_autoplay_test.cc
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/4b48f2def6c7d240fc4242a4ed8e3cb4fe8b3986/third_party/blink/renderer/modules/webaudio/offline_audio_context.h

Comment 3 by monor...@bugs.chromium.org, Jun 14 2018 

The NextAction date has arrived: 2018-06-14

Comment 4 by hongchan@chromium.org, Jun 19 2018

Status: Verified (was: Started)
►

Sign in to add a comment