New issue
Advanced search Search tips

Issue 851605 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebAudio layout tests fail on Win10

Project Member Reported by rtoy@chromium.org, Jun 11 2018

Issue description

These tests fail for me on win10 machine:


external/wpt/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse.html
webaudio/Oscillator/osc-sweep-snr-custom.html
webaudio/Oscillator/osc-sweep-snr-sawtooth.html
webaudio/Oscillator/osc-sweep-snr-sine.html
webaudio/Oscillator/osc-sweep-snr-square.html
webaudio/Oscillator/osc-sweep-snr-triangle.html


The error thresholds are a bit too tight.

This aren't failing on any bots right now, but I assume they will someday when win10 bots are available.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47627e1bce1e4a1e7599b9c831520f403f287f99

commit 47627e1bce1e4a1e7599b9c831520f403f287f99
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Jun 11 22:50:08 2018

Adjust test thresholds for win10

These tests fail on Windows 10 because the error thresholds are a bit
too tight.  Relax them a bit so that these pass on my Win10 machine.

Bug:  851605 
Change-Id: Ie7795205550a43928e7f0963e4411264e3ded37b
Reviewed-on: https://chromium-review.googlesource.com/1095859
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566181}
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse.html
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-custom.html
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-sawtooth.html
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-sine.html
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-square.html
[modify] https://crrev.com/47627e1bce1e4a1e7599b9c831520f403f287f99/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-triangle.html

Comment 2 by rtoy@chromium.org, Jun 12 2018

Status: Fixed (was: Started)

Sign in to add a comment