Swarming isolate/isolated distribution to formal CIPD packages |
||||||||||||
Issue descriptionThanks to Vadim, it's already mostly done; https://chromium.googlesource.com/infra/infra.git/+/8b15ba47cbaf07a56f93326e39f0c8e5069c19e8/build/packages/isolate.yaml AIs: - Remove the old 'upload to GS'. - Change src.git/DEPS to fetch the binaries via CIPD. The packages are infra/tools/luci/isolate and infra/tools/luci/isolated. It can be pinned via git_revision:8b15ba47cbaf07a56f93326e39f0c8e5069c19e8 or something similar. Andrii is transitioning the builders to LUCI. He agreed to remove the gs upload part, I'll do the DEPS change.
,
Jun 11 2018
- Remove the old 'upload to GS'. https://chromium-review.googlesource.com/#/c/infra/infra/+/1096278
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/187eb09835a18b5521eb2437b802e4a274524975 commit 187eb09835a18b5521eb2437b802e4a274524975 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Jun 13 14:35:54 2018 infra CI: no longer upload isolatego binary to GS. isolatego will from now on be deployed as CIPD package. R=maruel@chromium.org Bug: 851596 Change-Id: I727cfd5071ee44f76efd2ec9f068f3fbc1d56155 Reviewed-on: https://chromium-review.googlesource.com/1096278 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/187eb09835a18b5521eb2437b802e4a274524975/recipes/recipes/infra_continuous.expected/infra-continuous-win-64.json [modify] https://crrev.com/187eb09835a18b5521eb2437b802e4a274524975/recipes/README.recipes.md [modify] https://crrev.com/187eb09835a18b5521eb2437b802e4a274524975/recipes/recipes/infra_continuous.py [modify] https://crrev.com/187eb09835a18b5521eb2437b802e4a274524975/recipes/recipes/infra_continuous.expected/infra-continuous-trusty-64.json
,
Jun 19 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1b4a81e370abaa005924effa741e2207622761a9 commit 1b4a81e370abaa005924effa741e2207622761a9 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed Jun 20 14:32:22 2018 isolate: update wrapper script to use new isolate Go tool under src/ With the move to distribution via CIPD, it's now always downloaded at the same place, and not inside a directory named against the OS. Keep the old location working too, so that old checkouts are not (yet) broken. Do not fix the iOS recipe yet, will do in a separate change. Bug: 851596 Change-Id: Ic10959ce0f9bae8d4c452cca00d11d6a94f71c65 Reviewed-on: https://chromium-review.googlesource.com/1106006 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/1b4a81e370abaa005924effa741e2207622761a9/scripts/slave/recipe_modules/isolate/resources/isolate.py
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03 commit 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Jun 22 17:52:21 2018 Add luci-go tool to be fetched via CIPD Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes need to be updated. Change analyze to not ignore changes to isolate. R=tandrii@chromium.org Bug: 851596 Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 Reviewed-on: https://chromium-review.googlesource.com/1097623 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569688} [modify] https://crrev.com/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03/DEPS [modify] https://crrev.com/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03/testing/buildbot/trybot_analyze_config.json [modify] https://crrev.com/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03/tools/luci-go/.gitignore [modify] https://crrev.com/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03/tools/luci-go/OWNERS [modify] https://crrev.com/3bcc71d83f6d9af93a7408fbea34f6d5f0185c03/tools/luci-go/README.md
,
Jun 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c062061326cd05a1ab884e5b2d6e03e2b79f215 commit 0c062061326cd05a1ab884e5b2d6e03e2b79f215 Author: John Budorick <jbudorick@chromium.org> Date: Sun Jun 24 21:33:26 2018 Revert "Add luci-go tool to be fetched via CIPD" This reverts commit 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03. Reason for revert: appears to break official builds due to how the cipd variable is flattened. Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Presubmit: true Bug: 851596 Change-Id: I3717c6b0ebf68b08908037850d122727e41bf192 Reviewed-on: https://chromium-review.googlesource.com/1112823 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569938} [modify] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/DEPS [modify] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/testing/buildbot/trybot_analyze_config.json [modify] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/tools/luci-go/.gitignore [modify] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/tools/luci-go/OWNERS [modify] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/tools/luci-go/README.md
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e4521b85960399cd22afe33dddaa4516c53f271 commit 4e4521b85960399cd22afe33dddaa4516c53f271 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed Jul 04 01:27:35 2018 Reland "Add luci-go tool to be fetched via CIPD" This is a reland of 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03 Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} Bug: 851596 Change-Id: I27382d97370376dcca8110c9225c16dada182256 Reviewed-on: https://chromium-review.googlesource.com/1125000 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572435} [modify] https://crrev.com/4e4521b85960399cd22afe33dddaa4516c53f271/DEPS [modify] https://crrev.com/4e4521b85960399cd22afe33dddaa4516c53f271/testing/buildbot/trybot_analyze_config.json [modify] https://crrev.com/4e4521b85960399cd22afe33dddaa4516c53f271/tools/luci-go/.gitignore [modify] https://crrev.com/4e4521b85960399cd22afe33dddaa4516c53f271/tools/luci-go/OWNERS [modify] https://crrev.com/4e4521b85960399cd22afe33dddaa4516c53f271/tools/luci-go/README.md
,
Jul 4
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3f4779bbe0debc13f892264cd780bdb74b6871 commit 5f3f4779bbe0debc13f892264cd780bdb74b6871 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed Jul 04 12:54:35 2018 Revert "Reland "Add luci-go tool to be fetched via CIPD"" This reverts commit 4e4521b85960399cd22afe33dddaa4516c53f271. Reason for revert: This broke the code search builder. Reverting since everyone in the US is OOO, so this wouldn't be fixed for at least two days. Bug: 860239 Original change's description: > Reland "Add luci-go tool to be fetched via CIPD" > > This is a reland of 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03 > > Original change's description: > > Add luci-go tool to be fetched via CIPD > > > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > > need to be updated. > > > > Change analyze to not ignore changes to isolate. > > > > R=tandrii@chromium.org > > > > Bug: 851596 > > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > > Reviewed-on: https://chromium-review.googlesource.com/1097623 > > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#569688} > > Bug: 851596 > Change-Id: I27382d97370376dcca8110c9225c16dada182256 > Reviewed-on: https://chromium-review.googlesource.com/1125000 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572435} TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ia95f851c24fab175827fc2a7d5d1472713b909af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596 Reviewed-on: https://chromium-review.googlesource.com/1125900 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572546} [modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/DEPS [modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/testing/buildbot/trybot_analyze_config.json [modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/.gitignore [modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/OWNERS [modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/README.md
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/50965d13c8f495a73b15f8b0e46b3069fb95e316 commit 50965d13c8f495a73b15f8b0e46b3069fb95e316 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Wed Jul 04 13:18:38 2018 [V8] Correct the parsing logic to allow dep contain column in the key Columns are returned by gclient-revinfo for CIPD deps. R=machenbach@chromium.org Bug: 851596 Change-Id: Ifdab9d0dc9011800eb5a614a069c30756e75bb5e Reviewed-on: https://chromium-review.googlesource.com/1125839 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/50965d13c8f495a73b15f8b0e46b3069fb95e316/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/experimental_roll_v8_deps.json [modify] https://crrev.com/50965d13c8f495a73b15f8b0e46b3069fb95e316/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json [modify] https://crrev.com/50965d13c8f495a73b15f8b0e46b3069fb95e316/scripts/slave/recipes/v8/auto_roll_v8_deps.py
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/f3c09e56bc7f57116edbe9460acf911aced698e4 commit f3c09e56bc7f57116edbe9460acf911aced698e4 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Wed Jul 04 16:26:18 2018 [V8] Do not fail to create roll CL when dep changes repository TBR=machenbach@chromium.org Bug: 851596 Change-Id: Ieb5fb2218b72bb3028979411d16883abe6b79f0b Reviewed-on: https://chromium-review.googlesource.com/1125840 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/f3c09e56bc7f57116edbe9460acf911aced698e4/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/experimental_roll_v8_deps.json [modify] https://crrev.com/f3c09e56bc7f57116edbe9460acf911aced698e4/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json [modify] https://crrev.com/f3c09e56bc7f57116edbe9460acf911aced698e4/scripts/slave/recipes/v8/auto_roll_v8_deps.py
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8181595470db26090b29814229390edfb5727dca commit 8181595470db26090b29814229390edfb5727dca Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Jul 13 00:26:44 2018 3rd reland "Add luci-go tool to be fetched via CIPD" This is a reland of 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03 Now code search should be fine. Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} Bug: 851596 Change-Id: Icd227efde182ff844e93dbb692124c1297ab0d7c Reviewed-on: https://chromium-review.googlesource.com/1135791 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574787} [modify] https://crrev.com/8181595470db26090b29814229390edfb5727dca/DEPS [modify] https://crrev.com/8181595470db26090b29814229390edfb5727dca/testing/buildbot/trybot_analyze_config.json [modify] https://crrev.com/8181595470db26090b29814229390edfb5727dca/tools/luci-go/.gitignore [modify] https://crrev.com/8181595470db26090b29814229390edfb5727dca/tools/luci-go/OWNERS [modify] https://crrev.com/8181595470db26090b29814229390edfb5727dca/tools/luci-go/README.md
,
Jul 13
,
Jul 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad108787e77ffdf24681aa14fb87e51e2dadf8c1 commit ad108787e77ffdf24681aa14fb87e51e2dadf8c1 Author: Andrew Grieve <agrieve@chromium.org> Date: Sat Jul 14 02:56:01 2018 Add .gitignore for //tools/luci-go/.versions/isolate.cipd_version Bug: 851596 Change-Id: Id4c18ac2be3c5d05b426f4a0f84a9c46b12352e0 Reviewed-on: https://chromium-review.googlesource.com/1137707 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575139} [modify] https://crrev.com/ad108787e77ffdf24681aa14fb87e51e2dadf8c1/tools/luci-go/.gitignore
,
Jul 19
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bb055bef632b46bed7ee8e350c5de2278c67145 commit 6bb055bef632b46bed7ee8e350c5de2278c67145 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Thu Jul 19 17:37:09 2018 tools/luci-go: remove old way of mapping isolate It's now only mapped via CIPD, which is the right solution going forward. Bug: 851596,865541 Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e Reviewed-on: https://chromium-review.googlesource.com/1143448 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576550} [modify] https://crrev.com/6bb055bef632b46bed7ee8e350c5de2278c67145/DEPS [modify] https://crrev.com/6bb055bef632b46bed7ee8e350c5de2278c67145/tools/luci-go/.gitignore [delete] https://crrev.com/c542fbae9868eb330ccbe2bc65795ef30f6c26dd/tools/luci-go/linux64/isolate.sha1 [delete] https://crrev.com/c542fbae9868eb330ccbe2bc65795ef30f6c26dd/tools/luci-go/mac64/isolate.sha1 [delete] https://crrev.com/c542fbae9868eb330ccbe2bc65795ef30f6c26dd/tools/luci-go/win64/isolate.exe.sha1
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d0faaac3c79d920233fa8c93e2cf886123c840 commit 31d0faaac3c79d920233fa8c93e2cf886123c840 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Fri Jul 20 09:52:41 2018 Revert "tools/luci-go: remove old way of mapping isolate" This reverts commit 6bb055bef632b46bed7ee8e350c5de2278c67145. Reason for revert: P0 bug https://crbug.com/865882 Original change's description: > tools/luci-go: remove old way of mapping isolate > > It's now only mapped via CIPD, which is the right solution going forward. > > Bug: 851596,865541 > Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e > Reviewed-on: https://chromium-review.googlesource.com/1143448 > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576550} TBR=maruel@chromium.org,tandrii@chromium.org,jbudorick@chromium.org Change-Id: I2d432e9c80379c41e22b7a1cfdb4ea3f54586baa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596, 865541 Reviewed-on: https://chromium-review.googlesource.com/1145020 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576823} [modify] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/DEPS [modify] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/.gitignore [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/linux64/isolate.sha1 [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/mac64/isolate.sha1 [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/win64/isolate.exe.sha1
,
Jul 20
,
Jul 20
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45a93161c50a2ede188b8ba5d8892ef76431c00d commit 45a93161c50a2ede188b8ba5d8892ef76431c00d Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Mon Jul 23 14:59:37 2018 Revert "tools/luci-go: remove old way of mapping isolate" This reverts commit 6bb055bef632b46bed7ee8e350c5de2278c67145. Reason for revert: P0 bug https://crbug.com/865882 Original change's description: > tools/luci-go: remove old way of mapping isolate > > It's now only mapped via CIPD, which is the right solution going forward. > > Bug: 851596,865541 > Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e > Reviewed-on: https://chromium-review.googlesource.com/1143448 > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576550} TBR=maruel@chromium.org,tandrii@chromium.org,jbudorick@chromium.org Change-Id: I2d432e9c80379c41e22b7a1cfdb4ea3f54586baa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596, 865541, 865882 Reviewed-on: https://chromium-review.googlesource.com/1145020 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576823}(cherry picked from commit 31d0faaac3c79d920233fa8c93e2cf886123c840) Reviewed-on: https://chromium-review.googlesource.com/1146841 Reviewed-by: John Budorick <jbudorick@google.com> Cr-Commit-Position: refs/branch-heads/3497@{#14} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/DEPS [modify] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/.gitignore [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/linux64/isolate.sha1 [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/mac64/isolate.sha1 [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/win64/isolate.exe.sha1
,
Jul 26
,
Jul 26
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6 commit d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6 Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Dec 06 15:29:28 2018 [swarming] Remove non CIPD managed luci-go package Bug: 851596 Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547 Reviewed-on: https://chromium-review.googlesource.com/c/1364976 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614359} [modify] https://crrev.com/d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6/DEPS [modify] https://crrev.com/d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6/tools/luci-go/.gitignore [delete] https://crrev.com/763b79a9142f3f063eca4504dc9a45b7e75e252f/tools/luci-go/linux64/isolate.sha1 [delete] https://crrev.com/763b79a9142f3f063eca4504dc9a45b7e75e252f/tools/luci-go/mac64/isolate.sha1 [delete] https://crrev.com/763b79a9142f3f063eca4504dc9a45b7e75e252f/tools/luci-go/win64/isolate.exe.sha1
,
Dec 6
Is this fixed now?
,
Dec 6
Looks like yes. \o/
,
Dec 7
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/60d770f2ef84afbb75300b277587bdee26fe1010 commit 60d770f2ef84afbb75300b277587bdee26fe1010 Author: Artem Titarenko <artit@webrtc.org> Date: Fri Dec 07 15:35:22 2018 Replace luci-go dependency to CIPD package This is needed to be compatible with chromium change, see bug for details. BUG=chromium:851596 Change-Id: I7b3ffda3715e925c42f4b95a2ba1d3f5cf829fda Reviewed-on: https://webrtc-review.googlesource.com/c/113504 Commit-Queue: Artem Titarenko <artit@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25933} [modify] https://crrev.com/60d770f2ef84afbb75300b277587bdee26fe1010/DEPS
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d33127fd0f01784c99ace087a4346c4d8b54cca6 commit d33127fd0f01784c99ace087a4346c4d8b54cca6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 07 20:04:55 2018 Roll src/third_party/webrtc 10b051083c0d..4348ce240aae (3 commits) https://webrtc.googlesource.com/src.git/+log/10b051083c0d..4348ce240aae git log 10b051083c0d..4348ce240aae --date=short --no-merges --format='%ad %ae %s' 2018-12-07 ilnik@webrtc.org Calculate min and max receive timestamps for packets in a video frame 2018-12-07 nisse@webrtc.org Convert all webrtc code to not access EncodedImage::_size directly. 2018-12-07 artit@webrtc.org Replace luci-go dependency to CIPD package Created with: gclient setdep -r src/third_party/webrtc@4348ce240aae The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:851596 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I30370412edd578d87e1a5c88dacb976e648bcf4a Reviewed-on: https://chromium-review.googlesource.com/c/1367968 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614795} [modify] https://crrev.com/d33127fd0f01784c99ace087a4346c4d8b54cca6/DEPS
,
Dec 10
Seems we need to do some more tasks. https://bugs.chromium.org/p/chromium/issues/detail?id=913158
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ccdcf4045144a735a84138ab6b41c3098808d2 commit 17ccdcf4045144a735a84138ab6b41c3098808d2 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Dec 11 00:30:55 2018 Revert "[swarming] Remove non CIPD managed luci-go package" This reverts commit d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6. Reason for revert: broke internal builder https://bugs.chromium.org/p/chromium/issues/detail?id=913158 Original change's description: > [swarming] Remove non CIPD managed luci-go package > > Bug: 851596 > Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547 > Reviewed-on: https://chromium-review.googlesource.com/c/1364976 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614359} TBR=maruel@chromium.org,tikuta@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851596, 913158 Change-Id: Ic2efd0397871271df5c0d41a0731088d53386f71 Reviewed-on: https://chromium-review.googlesource.com/c/1370225 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615346} [modify] https://crrev.com/17ccdcf4045144a735a84138ab6b41c3098808d2/DEPS [modify] https://crrev.com/17ccdcf4045144a735a84138ab6b41c3098808d2/tools/luci-go/.gitignore [add] https://crrev.com/17ccdcf4045144a735a84138ab6b41c3098808d2/tools/luci-go/linux64/isolate.sha1 [add] https://crrev.com/17ccdcf4045144a735a84138ab6b41c3098808d2/tools/luci-go/mac64/isolate.sha1 [add] https://crrev.com/17ccdcf4045144a735a84138ab6b41c3098808d2/tools/luci-go/win64/isolate.exe.sha1 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tandrii@chromium.org
, Jun 11 2018