New issue
Advanced search Search tips

Issue 851573 link

Starred by 1 user
Status: WontFix
Owner:
wychen@chromium.org
Closed: Jun 2018
Cc:
tzik@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

bind_unittest_nc fails to compile

Project Member Reported by a...@chromium.org, Jun 11 2018 
If I do "ninja build all", the bind NC test in my tree fails:

gen/base/bind_unittest_nc.cc:24:2: error: "NCTEST_DISALLOW_ASSIGN_DIFFERENT_TYPES Failed: Compile timed out. Started 1528317476.947482 ended 1528317537.857620."
#error "NCTEST_DISALLOW_ASSIGN_DIFFERENT_TYPES Failed: Compile timed out. Started 1528317476.947482 ended 1528317537.857620."
 ^
gen/base/bind_unittest_nc.cc:25:2: error: "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_ASSIGN_DIFFERENT_TYPES -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_ASSIGN_DIFFERENT_TYPES -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
 ^
gen/base/bind_unittest_nc.cc:35:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Compile timed out. Started 1528317477.348363 ended 1528317537.857620."
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Compile timed out. Started 1528317477.348363 ended 1528317537.857620."
 ^
gen/base/bind_unittest_nc.cc:36:2: error: "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_CAPTURING_LAMBDA -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_CAPTURING_LAMBDA -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
 ^
gen/base/bind_unittest_nc.cc:42:2: error: "NCTEST_DISALLOW_ONCECALLBACK_RUN_ON_LVALUE Failed: Compile timed out. Started 1528317477.849658 ended 1528317537.857620."
#error "NCTEST_DISALLOW_ONCECALLBACK_RUN_ON_LVALUE Failed: Compile timed out. Started 1528317477.849658 ended 1528317537.857620."
 ^
gen/base/bind_unittest_nc.cc:43:2: error: "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_ONCECALLBACK_RUN_ON_LVALUE -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_DISALLOW_ONCECALLBACK_RUN_ON_LVALUE -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
 ^
gen/base/bind_unittest_nc.cc:59:2: error: "NCTEST_WEAKPTR_BIND_MUST_RETURN_VOID Failed: Compile timed out. Started 1528317476.501995 ended 1528317537.857620."
#error "NCTEST_WEAKPTR_BIND_MUST_RETURN_VOID Failed: Compile timed out. Started 1528317476.501995 ended 1528317537.857620."
 ^
gen/base/bind_unittest_nc.cc:60:2: error: "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_WEAKPTR_BIND_MUST_RETURN_VOID -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /Volumes/src/chrome-git/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ --sysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -MMD -MF gen/base/bind_unittest_nc.cc.d -MT gen/base/bind_unittest_nc.cc -DNCTEST_WEAKPTR_BIND_MUST_RETURN_VOID -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
 ^
8 errors generated.

Assigning to you, Nico. Probably not you but you'll know who should look at it.

Comment 1 by thakis@chromium.org, Jun 11 2018

Cc: tzik@chromium.org wychen@chromium.org
Components: Build
Owner: ----
Status: Untriaged (was: Assigned)
_nc means "no compile", so it's supposed to fail to compile. But it's also not supposed to be built as part of a regular build; there's supposed to be a no compile driver that runs nocompile tests...somewhere.

I think the nc tests cause more issues than they solve (cf eg this bug). Someone maintains them though, maybe wychen or tzik?

Comment 2 by a...@chromium.org, Jun 11 2018 

I always do "ninja -C out/debug all" all the time, as I do refactors and I want to make sure *everything* works. I've never had NC test issues before. This NC test failure issue is new the past week or two.

Comment 3 by wychen@chromium.org, Jun 11 2018

Cc: -wychen@chromium.org
Owner: wychen@chromium.org
Status: Assigned (was: Untriaged)
The nc tests are covered by buildbots, but not all configurations.

thakis@ is right on the maintenance issue. Since it's one of its kind, it does cause some issues from time to time. Call me a hoarder, but I'm a bit reluctant to let go this, given this is the first incident in 2018.

Is this Mac only? I couldn't repro on linux.

Comment 4 by wychen@chromium.org, Jun 12 2018 

I just gave it a try on my Macbook, but couldn't reproduce it. Is this timeout a flaky failure? Could it be that your machine was overloaded or thrashing so that the compilation couldn't finish within the 60s timeout?

Comment 5 by a...@chromium.org, Jun 12 2018 

It's consistently that one file. No other file has an issue.

I'll try a clean build tomorrow.

Comment 6 by a...@chromium.org, Jun 12 2018

Status: WontFix (was: Assigned)
This has gone away after a clean build.
►

Sign in to add a comment