New issue
Advanced search Search tips

Issue 851571 link

Starred by 1 user
Status: Fixed
Owner:
manukh@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 823535



Sign in to add a comment

Material Refresh - Location Bar insets need to be changed slightly for Refresh

Project Member Reported by tommycli@chromium.org, Jun 11 2018 
See the redline mocks. Currently the insets are 4 for both horiz and vert. I think the insets need to be 6 horiz and 5 vert for MD Refresh only.

This is for the RoundedOmniboxResultsFrame

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h?q=RoundedOmnib&sq=package:chromium&g=0&l=17
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f307eed75f2ed8a2c508997f307ed70b192ef52

commit 9f307eed75f2ed8a2c508997f307ed70b192ef52
Author: manuk <manukh@chromium.org>
Date: Tue Jun 12 21:20:35 2018

Increase omnibox's raised state's inset size when material design is enabled

Inset size used to be 4 vertically and 4 horizontally, regardless of material design status.
Inset size increased to 5 vertically and 6 horizontally when material design is active.

Bug:  851571 
Change-Id: Id53249484e69499ec3317d7ba1ced49ea8318369
Reviewed-on: https://chromium-review.googlesource.com/1097456
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566574}
[modify] https://crrev.com/9f307eed75f2ed8a2c508997f307ed70b192ef52/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/9f307eed75f2ed8a2c508997f307ed70b192ef52/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/9f307eed75f2ed8a2c508997f307ed70b192ef52/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
[modify] https://crrev.com/9f307eed75f2ed8a2c508997f307ed70b192ef52/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
[modify] https://crrev.com/9f307eed75f2ed8a2c508997f307ed70b192ef52/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h

Comment 2 by manukh@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment