With bug 759710 fixed, gmock now supports move-only types in function parameters. We currently have a bunch of unit tests that had to workaround the previous lack of support. We should be able to remove the workarounds now as a cleanup.
I'm doing this for PresentationServiceImpl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756d07e6ffaab2d19b2a7fa478090727518ba3ab commit 756d07e6ffaab2d19b2a7fa478090727518ba3ab Author: mark a. foltz <mfoltz@chromium.org> Date: Fri Jul 20 20:59:18 2018 [Presentation API] Remove content::PresentationConnectionMessage This replaces usages of content::PresentationConnectionMessage with blink::mojom::PresentationConnectionMessagePtr, and removes the presentation.mojom typemap and traits which are no longer needed. This is the last step before we can move presentation.mojom to third_party/blink/public/mojom. It also updates relevant unittests to mock methods with move parameters directly, instead of using helper methods. Bug: 817903 ,851567 Change-Id: Ifc50db81108f78089e7f19a7a394069bb2b82b37 Reviewed-on: https://chromium-review.googlesource.com/1123175 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576981} [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/local_presentation_manager.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/route_message_util.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/route_message_util.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/test/test_helper.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/OWNERS [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/common/BUILD.gn [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/OWNERS [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation.typemap [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation_struct_traits.cc [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation_struct_traits.h [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/typemaps.gni [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/public/browser/presentation_service_delegate.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/public/common/BUILD.gn [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/public/common/presentation_connection_message.cc [delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/public/common/presentation_connection_message.h [modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/mojo/public/tools/bindings/chromium_bindings_configuration.gni
Comment 1 by mfo...@chromium.org
, Jul 2Status: Started (was: Available)