[standalone] VR: Chrome floor height too high on standalone devices. |
||||||
Issue descriptionIt seems that frequently the standalone device fails to detect the actual floor height, and the default we use makes the user feel extremely short - like the content window is pretty high up. We should revert to the pre-dynamic-floor-height behavior for now and figure out how to handle this in the future.
,
Jun 14 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2b32b44ee00b3410aa5a19865bac4a8a5b7fdb4 commit c2b32b44ee00b3410aa5a19865bac4a8a5b7fdb4 Author: Brandon Jones <bajones@chromium.org> Date: Fri Jun 15 17:07:52 2018 Removed the check for floor height on standalone VR Bug: 851544 Change-Id: I0504db37dce23a2cbc69624a30452e328c8d9a84 Reviewed-on: https://chromium-review.googlesource.com/1101998 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#567699} [modify] https://crrev.com/c2b32b44ee00b3410aa5a19865bac4a8a5b7fdb4/chrome/browser/android/vr/vr_shell_gl.cc
,
Jun 15 2018
,
Jun 15 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
ping on merge request. thanks.
,
Jun 18 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83b71ea3e2f0e622b9f257f278cb6b96e69fd2b0 commit 83b71ea3e2f0e622b9f257f278cb6b96e69fd2b0 Author: Brandon Jones <bajones@chromium.org> Date: Mon Jun 18 19:25:27 2018 Removed the check for floor height on standalone VR Bug: 851544 Change-Id: I0504db37dce23a2cbc69624a30452e328c8d9a84 Reviewed-on: https://chromium-review.googlesource.com/1101998 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567699}(cherry picked from commit c2b32b44ee00b3410aa5a19865bac4a8a5b7fdb4) Reviewed-on: https://chromium-review.googlesource.com/1104823 Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#408} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/83b71ea3e2f0e622b9f257f278cb6b96e69fd2b0/chrome/browser/android/vr/vr_shell_gl.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ericde@chromium.org
, Jun 14 2018