test_push is trying to update prod servers! |
|||
Issue descriptiontest_push is trying to push the prod drones and shards instead of the staging ones. This update fails very early due to issue 850118 If that hadn't been failing, we would have ended up with all shards/drones at ToT instead of tip-of-prod, likely causing catastrophic failure. Root cause: CL:1087506 changed the default behaviour of 'atest server' to use --skylab. But with --skylab, '--env' needs to be explicitly provided to pick the env to target, defaulting to prod.
,
Jun 11 2018
I have a CL to explicitly pick staging servers for test push: https://chrome-internal-review.googlesource.com/#/c/chromeos/chromeos-admin/+/638888 But there are a couple points to consider: - Perhaps CL:1087506 was landed too soon -- all known users of 'atest server' should have been explicitly changed to use '--skylab' to catch cases like this one. - This means that there might be other places this is a problem that can cause staging/prod mixing. Which is dangerous.
,
Jun 11 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/a097951ac26d1335b3d0c8dfacc2a69b02a8038c commit a097951ac26d1335b3d0c8dfacc2a69b02a8038c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Jun 11 19:25:13 2018
,
Jun 11 2018
,
Jun 11 2018
Looks like you're working on this...?
,
Jun 12 2018
#3 landed, but staging master doesn't update ~/chromiumos repo before trying to use it. So needed a manual 'repo sync' Also, I found that we don't run repo sync with --force-sync, so that some projects are stuck in a bad state. (perhaps also in prod).
,
Jun 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/dd7be80fcfec644f8b26b224bd81eb6b7f25ea4b commit dd7be80fcfec644f8b26b224bd81eb6b7f25ea4b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 12 17:46:59 2018
,
Jun 12 2018
test_push is still stuck because the stupid thing can't update the servers correctly even after all required changes have landed. Tracking on issue 852028.
,
Jun 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/390e346f960ed952e040272ae672b6e61af043e1 commit 390e346f960ed952e040272ae672b6e61af043e1 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 12 18:18:51 2018
,
Jul 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d77bf0d3f9e2fd4f4a79c592ad7c4df7db31cd03 commit d77bf0d3f9e2fd4f4a79c592ad7c4df7db31cd03 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Jul 07 01:48:50 2018 deploy_server: Run 'repo sync' with --force-sync Some project updates require re-initializing the git checkout. This is the right thing to do for prod deployments. BUG= chromium:851538 TEST=None Change-Id: I64648e5292bf18e33936040a88a926c5e338107b Reviewed-on: https://chromium-review.googlesource.com/1097497 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/d77bf0d3f9e2fd4f4a79c592ad7c4df7db31cd03/site_utils/deploy_server_local.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by pprabhu@chromium.org
, Jun 11 2018