Triage: please add estimated days thanks!

FYI This might be understating it depending on how tricky it'll be to add text, the existing implementation is built on top of a button that only supports an image.

 Issue 853363  has been merged into this issue.

Triage friendly ping: how's this going?

Some things (adding the text label) turns out easier than expected. We'll try reusing the inkdrop to get the specified colors. Blocking this on a crash in the InkDrop when we're resizing the view.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67dfce1fde18a82e97527ad3c755b2e9ea720d07

commit 67dfce1fde18a82e97527ad3c755b2e9ea720d07
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jul 10 15:59:28 2018

Add AvatarToolbarButton error states

Adds an error label and corresponding styling to AvatarToolbarButton to
signal error and paused states. This is done through the following
changes:

* Turn ToolbarButton from an ImageButton to LabelButton. After turning
  RTL flipping on by default this has no visual impact on buttons that
  do not use the label text but allows AvatarToolbarButton to use a
  label.

* Style ToolbarButton for text by using the same label-to-image spacing
  as bookmarks. Increase left insets when text is visible.

* Add highlight-color support to ToolbarButton. For AvatarToolbarButton
  this is currently used as red for sync errors and blue for paused.
  When set, this color is permanently painted with low opacity as the
  ToolbarButton background. It's also used as the inkdrop base color.

* Add inset support to SolidRoundRectPainter. This is required to match
  the inkdrop shapes which are inset from the view edges. This is done
  so that ToolbarButtons are larger than their visible size on ChromeOS
  touch devices to provide larger hit targets that are easier to hit.

This change also makes several AvatarToolbarButton getters const by
turning AvatarButtonController::HasAvatarError() const.

This change also fixes a RTL issue where the avatar image was flipped.

Bug:  chromium:851530 ,  chromium:860416 
Change-Id: I06ee5eeb55d5b19cd57bb7b8445f05ead4ff1216
Reviewed-on: https://chromium-review.googlesource.com/1123172
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573752}
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/app/profiles_strings.grdp
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/avatar_button_error_controller.h
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/profiles/avatar_toolbar_button.h
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/ui/views/painter.cc
[modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/ui/views/painter.h

FWIW these look amazing.