Long-tapping on a tab scoots next tab over |
|||||||
Issue descriptionThis happens for me for any tab in normal or incognito: https://photos.app.goo.gl/4GKoQM5KyKpXVGhY7
,
Jun 12 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b3f098b2cc9d8741d65fba7891600982a887f63 commit 8b3f098b2cc9d8741d65fba7891600982a887f63 Author: Ryan Landay <rlanday@chromium.org> Date: Tue Jun 12 18:26:31 2018 Fix bug long pressing tabs in Android horizontal tab switcher The Android non-horizontal tab switcher with overlapping tabs has logic to show more of a tab (by scrolling other ones down) if you long press on it. This logic was inadvertently carried over to the new horizontal tab switcher, where it has odd results. This CL fixes this bug by moving this logic from Stack into OverlappingStack so we don't use it in NonOverlappingStack. Bug: 851521 ,831359 Change-Id: I98c18790a170661a221a61df109ed3ea050b6fd5 Reviewed-on: https://chromium-review.googlesource.com/1096477 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#566509} [modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java [modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/OverlappingStack.java [modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java
,
Jun 12 2018
,
Jun 12 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2018
Please verify in canary
,
Jun 13 2018
Verified in 69.0.3457.0
,
Jun 14 2018
,
Jun 14 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c3183cc0800365da3a3586bb816937f8ee5f4de commit 7c3183cc0800365da3a3586bb816937f8ee5f4de Author: Ryan Landay <rlanday@chromium.org> Date: Thu Jun 14 21:02:01 2018 Fix bug long pressing tabs in Android horizontal tab switcher The Android non-horizontal tab switcher with overlapping tabs has logic to show more of a tab (by scrolling other ones down) if you long press on it. This logic was inadvertently carried over to the new horizontal tab switcher, where it has odd results. This CL fixes this bug by moving this logic from Stack into OverlappingStack so we don't use it in NonOverlappingStack. Bug: 851521 ,831359 Change-Id: I98c18790a170661a221a61df109ed3ea050b6fd5 Reviewed-on: https://chromium-review.googlesource.com/1096477 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566509}(cherry picked from commit 8b3f098b2cc9d8741d65fba7891600982a887f63) Reviewed-on: https://chromium-review.googlesource.com/1101738 Reviewed-by: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#364} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java [modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/OverlappingStack.java [modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rlanday@chromium.org
, Jun 11 2018