New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 831359



Sign in to add a comment

Long-tapping on a tab scoots next tab over

Project Member Reported by sbirch@chromium.org, Jun 11 2018

Issue description

This happens for me for any tab in normal or incognito:

https://photos.app.goo.gl/4GKoQM5KyKpXVGhY7
 
Labels: -Pri-3 Pri-1
Blocking: 831359
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3f098b2cc9d8741d65fba7891600982a887f63

commit 8b3f098b2cc9d8741d65fba7891600982a887f63
Author: Ryan Landay <rlanday@chromium.org>
Date: Tue Jun 12 18:26:31 2018

Fix bug long pressing tabs in Android horizontal tab switcher

The Android non-horizontal tab switcher with overlapping tabs has logic to show
more of a tab (by scrolling other ones down) if you long press on it. This logic
was inadvertently carried over to the new horizontal tab switcher, where it has
odd results.

This CL fixes this bug by moving this logic from Stack into OverlappingStack so
we don't use it in NonOverlappingStack.

Bug:  851521 ,831359
Change-Id: I98c18790a170661a221a61df109ed3ea050b6fd5
Reviewed-on: https://chromium-review.googlesource.com/1096477
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566509}
[modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java
[modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/OverlappingStack.java
[modify] https://crrev.com/8b3f098b2cc9d8741d65fba7891600982a887f63/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java

Labels: Merge-Request-68
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 12 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Jun 12 2018

Please verify in canary
Verified in 69.0.3457.0

Comment 8 by cma...@chromium.org, Jun 14 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 14 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3183cc0800365da3a3586bb816937f8ee5f4de

commit 7c3183cc0800365da3a3586bb816937f8ee5f4de
Author: Ryan Landay <rlanday@chromium.org>
Date: Thu Jun 14 21:02:01 2018

Fix bug long pressing tabs in Android horizontal tab switcher

The Android non-horizontal tab switcher with overlapping tabs has logic to show
more of a tab (by scrolling other ones down) if you long press on it. This logic
was inadvertently carried over to the new horizontal tab switcher, where it has
odd results.

This CL fixes this bug by moving this logic from Stack into OverlappingStack so
we don't use it in NonOverlappingStack.

Bug:  851521 ,831359
Change-Id: I98c18790a170661a221a61df109ed3ea050b6fd5
Reviewed-on: https://chromium-review.googlesource.com/1096477
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566509}(cherry picked from commit 8b3f098b2cc9d8741d65fba7891600982a887f63)
Reviewed-on: https://chromium-review.googlesource.com/1101738
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#364}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java
[modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/OverlappingStack.java
[modify] https://crrev.com/7c3183cc0800365da3a3586bb816937f8ee5f4de/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java

Sign in to add a comment