New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851515 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

GPay logo does not properly show or animate after a credit card suggestion is selected.

Project Member Reported by mahmadi@chromium.org, Jun 11 2018

Issue description

Chrome Version: 69.0.3455.0
OS: iOS

What steps will reproduce the problem?
(1) Enable chrome://flags/#enable-autofill-credit-card-downstream-google-pay-branding
(2) Go to https://rsolomakhin.github.io/autofill/
(3) Interact with a credit card field and observe the GPay logo appear as the first suggestion and animate.
(4) Select a suggestion so that the credit card unmask prompt UI appears. Dismiss the UI.
(5) Interact with another credit card field and observe that the GPay logo appears as the last suggestion now and doesn't animate

Selecting a suggestion should not alter the behavior or the GPay logo.



 
gpay-downstream.mp4
2.7 MB View Download
Cc: rfeng@chromium.org

Comment 3 by dlkumar@google.com, Jun 13 2018

Thanks Mohammad. I am able to re-produce the issue. 

What is happening here is - Chrome is using "frecency" algorithm to re-order cards when selection is done. So after selecting card, even discarding it is resulting in frecency algorithm that is keeping card before "Gpay" logo suggestion. We can play with this well if we have two cards as suggestions.

I checked how this is handled in Desktop GPay branding to see if "Autofill settings" has any special sorting built in. In case of Autofill, frecency is not happening that frequent. 

Let me bring that up in team meeting tomorrow. Once I understand that, I guess fix should be relatively easy. 

Thanks for spotting this.



Do we not always add the GPay logo as the first option regardless of the sorting of the autofill suggestions?

Comment 5 by dlkumar@google.com, Jun 13 2018

We add it as first option when sending suggestions and thats why we see "GPay" is getting animated. After that it is getting sorted on frecency. What is interesting here is this seems to be specific iOS behavior as we don't see that re-ordering same page happens in other systems (Linux). 

Let me discuss in the team meeting.

Comment 6 by dlkumar@google.com, Jun 13 2018

Discussed in the team meeting and logged (https://bugs.chromium.org/p/chromium/issues/detail?id=852529). 
Cc: dlkumar@google.com
Owner: mahmadi@chromium.org
Assigning to Mohamad since he is doing the eng work on (https://bugs.chromium.org/p/chromium/issues/detail?id=852529) that should fix the issue here also. 

Sign in to add a comment