New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851512 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Stop building kevin board on ToT

Project Member Reported by jettrink@chromium.org, Jun 11 2018

Issue description

Kevin is running into space issues and we keep having to remove functionality to make it build on ToT. Since we already have another ARM-based board on ToT, we can remove kevin (and its maintenance burden).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9397e9bc054f8b1bd37d3d69043a3c982050db85

commit 9397e9bc054f8b1bd37d3d69043a3c982050db85
Author: Jett Rink <jettrink@chromium.org>
Date: Tue Jun 19 04:14:22 2018

gru: removing ec build from board build

We are removing kevin/gru from EC ToT and need to ensure that building
board kevin still works

BRANCH=none
BUG= chromium:851512 
TEST=build kevin board with all changes

Change-Id: Ic930f4ae4466d82f89a88fa9b6d3c47130471d1d
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1102565
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/9397e9bc054f8b1bd37d3d69043a3c982050db85/baseboard-gru/profiles/base/make.defaults

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/64aa8638f134f8aca4f48f3efc5fa7427caeb772

commit 64aa8638f134f8aca4f48f3efc5fa7427caeb772
Author: Jett Rink <jettrink@chromium.org>
Date: Fri Jun 22 02:56:34 2018

kevin/gru: remove board almost completely

Kevin/Gru are running out of space and we already have another ARM board on
ToT for development. Remove maintenance burden of keeping them around.

BRANCH=none
BUG= chromium:851512 
TEST=build_packages --board=kevin works with dependent CLs.
CQ-DEPEND=CL:1102565,CL:*640973,CL:*640974

Change-Id: Ie7c65c7799acc9f4d266e40b29b37240fec345c6
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1100011
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/gpio.inc
[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/led_gru.c
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/COMMIT-QUEUE.ini
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/extra/usb_power/board.README
[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/usb_pd_policy.c
[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/charge_ramp.c
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/board/kevin/board.h
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/board/kevin/ec.tasklist
[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/led_kevin.c
[delete] https://crrev.com/ab212b5a417e57fb452f3962a9a00d3bbda7345e/board/kevin/battery.c
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/board/kevin/board.c
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/board/kevin/build.mk
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/Makefile.rules
[modify] https://crrev.com/64aa8638f134f8aca4f48f3efc5fa7427caeb772/util/flash_ec

Components: Infra>Client>ChromeOS
Status: Verified (was: Assigned)
The final state of this issue is that build_packages for kevin (and gru) does not try to build the ec image from ToT; it just pulls in the pre-built image from binary component server (bcs).

However, we did leave a remnant of kevin (and gru) behind to allow `utils-host` make target for the EC to be built; this allows the chromeos-base/ec-devutils and chromeos-base/ec-utils portage packages to still build without issue, which is needed for the below dependencies:


$ equery-kevin d chromeos-base/ec-utils
 * These packages depend on chromeos-base/ec-utils:
chromeos-base/ec-devutils-0.0.2-r2913 (chromeos-base/ec-utils)
chromeos-base/factory_installer-0.0.1-r59 (chromeos-base/ec-utils)
chromeos-base/infineon-firmware-updater-1.1.2459.0-r25 (tpm_slb9655_v4_31 ? chromeos-base/ec-utils)
chromeos-base/power_manager-0.0.2-r2761 (chromeos-base/ec-utils)
virtual/target-chromium-os-test-1-r68 (chromeos-base/ec-utils)

$ equery-kevin d chromeos-base/ec-devutils
 * These packages depend on chromeos-base/ec-devutils:
dev-util/hdctools-0.0.1-r813 (chromeos-base/ec-devutils)
virtual/target-chromium-os-test-1-r68 (cros_ec ? chromeos-base/ec-devutils)

Sign in to add a comment