New issue
Advanced search Search tips

Issue 851505 link

Starred by 4 users
Status: WontFix
Owner:
tandrii@chromium.org
Closed: Sep 19
Cc:
tandrii@chromium.org
vapier@chromium.org
d...@chromium.org
jclinton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 847597


Sign in to add a comment

Deploy git 2.18.0 binaries

Project Member Reported by aga...@chromium.org, Jun 11 2018 
Git 2.18.0 is slated to be released on Sunday June 17. It will include full support for git protocol v2, including the ability to negotiate partial ref advertisement. This will greatly reduce the size of the ref advertisements sent between the git server and clients every time the clients do a fetch. In turn, this should greatly speed up fetch.

Note that this also requires setting 'git config protocol.version 2' or 'git -c protocol.version=2' to take advantage of the full capabilities

Comment 1 by d...@chromium.org, Jun 13 2018

Cc: d...@chromium.org
FYI, this CL should prepare Git to work with 2.18: https://chromium-review.googlesource.com/c/infra/infra/+/1097839

Comment 2 by aga...@chromium.org, Jun 13 2018 

Awesome, glad that exists already. And yep, the plan here is to
1) wait until the third_party_packages bot starts failing to build git 2.18.0, 2) then land that change,
3) then start rolling out the new version,
4) then roll out config changes to use protocol v2.

Comment 3 by d...@chromium.org, Jun 13 2018 

SGTM - I'll leave the CL in a prepared state so anyone can submit when necessary.

RE #4, are you planning on doing that w/ Puppet or Git wrapper? Just curious :)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7

commit 0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Jun 22 02:27:22 2018

[third_party_packages] Remove Git patches.

The Git patches have been upstreamed to Git, and are no longer needed.
Update the recipe to build Git directly.

This patch also fixes building problems with the new Git version by
bumping libcurl and adding libidn2 to the dependencies.

BUG= chromium:851505 
TEST=local

Change-Id: I400c65f9d8a0fa9237672c855b6b5b352b0576b8
Reviewed-on: https://chromium-review.googlesource.com/1097839
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_windows-386.json
[delete] https://crrev.com/6886c44fe640de8d1dd1e707339e27fc5ff7a4f8/recipes/recipe_modules/third_party_packages/resources/git/patches/0001-exec_cmd-self-resolution-and-relative-pathing.patch
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/swig.expected/new_on_mac-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/mac_specific_tag.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_mac-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/python.expected/mac_failure.json
[delete] https://crrev.com/6886c44fe640de8d1dd1e707339e27fc5ff7a4f8/recipes/recipe_modules/third_party_packages/resources/git/patches/0003-fetch-pack.c-use-oidset-to-check-existence-of-loose-.patch
[delete] https://crrev.com/6886c44fe640de8d1dd1e707339e27fc5ff7a4f8/recipes/recipe_modules/third_party_packages/resources/git/patches/README.md
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_windows-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_linux-amd64.json
[delete] https://crrev.com/6886c44fe640de8d1dd1e707339e27fc5ff7a4f8/recipes/recipe_modules/third_party_packages/resources/git/patches/0002-Infra-specific-extensions.patch
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/support_prefix.py
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/swig.expected/new_on_linux-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/swig.expected/new_on_linux-386.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/python.expected/new_on_linux-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipes/third_party_packages.expected/dry_run.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipes/third_party_packages.expected/basic.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/python.expected/new_on_linux-386.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_linux-386.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/mac_exists.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/python.expected/new_on_mac-amd64.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/windows_exists.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/resources/git/git_test.py
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/swig.expected/dry_run.json
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/git.py
[modify] https://crrev.com/0ce7e1f93d3c132249e0e3fde2dbb6c82b6727d7/recipes/recipe_modules/third_party_packages/examples/git.expected/dry_run.json
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/23b3d82eec600723b112745dcadea8bc681484a3

commit 23b3d82eec600723b112745dcadea8bc681484a3
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Jun 25 23:22:15 2018

[third_party_packages/git] add libcurl deps

Explicitly add libcurl deps so that they get linked in the correct
order. Prospective fix for current build failures.

BUG= chromium:851505 
TEST=expectations

Change-Id: I51bbacf5aa1e30d3b132d3a375b69252b752f159
Reviewed-on: https://chromium-review.googlesource.com/1114212
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_linux-amd64.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipes/third_party_packages.expected/dry_run.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipes/third_party_packages.expected/basic-buildbot.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipe_modules/third_party_packages/support_prefix.py
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_mac-amd64.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipes/third_party_packages.expected/basic.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipe_modules/third_party_packages/examples/git.expected/new_on_linux-386.json
[modify] https://crrev.com/23b3d82eec600723b112745dcadea8bc681484a3/recipes/recipe_modules/third_party_packages/examples/git.expected/dry_run.json

Comment 6 by d...@chromium.org, Jun 26 2018 

FYI, as of my last CL, we now have green Git builds on the full set of 1.18 builders, so this should be good to go: https://ci.chromium.org/p/infra-internal/g/third-party-packagers/builders

Comment 7 by dgarr...@chromium.org, Jun 27 2018

Cc: vapier@chromium.org jclinton@chromium.org
This seems like something ChromeOS wants, but I'm not certain of what's needed to fully deploy it.

Comment 8 by jclinton@chromium.org, Jun 27 2018 

Yes, we very much want this for the protocol improvement.

Comment 9 by vapier@chromium.org, Jun 27 2018 

considering `repo sync` and `chrome_sync` run outside of the SDK, we'd be using whatever git is installed on the buildbot.  so i don't think much work needs to be done on the CrOS side.

we can upgrade the SDK to 2.18, but we don't run git inside the chroot that much normally (for fetch operations), and same goes for DUTs.

Comment 10 by d...@chromium.org, Jun 27 2018 

RE #9, that is correct, and this bug, upon completion, should ensure that Git 2.18 is in use on both BuildBot and LUCI.

BuildBot: https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/cipd_bootstrap_v2.py#56
LUCI: https://chrome-internal.googlesource.com/infradata/config/+/master/configs/cr-buildbucket/swarming_task_template.json#51

Comment 11 by brucedaw...@chromium.org, Jul 16 

Any ETA on getting git 2.18 on Windows? I'm looking forward to some of the speedups - particularly important on Windows where git is famously slow.

Comment 12 by tandrii@chromium.org, Aug 8

Components: Infra>Platform
Owner: tandrii@chromium.org
Status: Started (was: Assigned)
So, it appears agable@ had to drop the ball on this one. I'll deploy it then.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d61997d37c8f7cc68080f39d4b516fb7b269b46c

commit d61997d37c8f7cc68080f39d4b516fb7b269b46c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Aug 08 22:00:01 2018

Deploy git 2.18 to depot_tools on a bleeding edge.

R=hinoka

Bug:  851505 
Change-Id: I3e13da0ec736fb3da4f4a95c71ed07c9a4fd0eca
Reviewed-on: https://chromium-review.googlesource.com/1168130
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/d61997d37c8f7cc68080f39d4b516fb7b269b46c/bootstrap/win/manifest_bleeding_edge.txt
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/99ad799e0e715011ab0cc7431e6ab87a7e30d333

commit 99ad799e0e715011ab0cc7431e6ab87a7e30d333
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Aug 08 22:10:56 2018
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9793ca2bf2700ffef99c7961dc604cc03f60831f

commit 9793ca2bf2700ffef99c7961dc604cc03f60831f
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Aug 08 22:14:25 2018

Deploy git 2.18 to canary buildbot slaves.

R=hinoka

Bug:  851505 
Change-Id: I2c235d3d2bb0ae43dacd177f73a387d25c1a6e80
Reviewed-on: https://chromium-review.googlesource.com/1168128
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/9793ca2bf2700ffef99c7961dc604cc03f60831f/scripts/slave/cipd_bootstrap_v2.py
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/5e24b0d07ea95e8a8e4a2b95069cd5cb571cd94e

commit 5e24b0d07ea95e8a8e4a2b95069cd5cb571cd94e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 00:51:59 2018

Revert "Deploy git 2.18 to depot_tools on a bleeding edge."

This reverts commit d61997d37c8f7cc68080f39d4b516fb7b269b46c.

Reason for revert: known to not work on mac, at least.

Original change's description:
> Deploy git 2.18 to depot_tools on a bleeding edge.
> 
> R=​hinoka
> 
> Bug:  851505 
> Change-Id: I3e13da0ec736fb3da4f4a95c71ed07c9a4fd0eca
> Reviewed-on: https://chromium-review.googlesource.com/1168130
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

TBR=hinoka@chromium.org,tandrii@chromium.org

Change-Id: Ie4c12e67cd50a9a4610a69dd55c43f444d79a9dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851505 
Reviewed-on: https://chromium-review.googlesource.com/1168350
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/5e24b0d07ea95e8a8e4a2b95069cd5cb571cd94e/bootstrap/win/manifest_bleeding_edge.txt
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/28982623f8e1fb5caed57f17efede475c89da466

commit 28982623f8e1fb5caed57f17efede475c89da466
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 00:52:12 2018

Revert "Deploy git 2.18 to canary buildbot slaves."

This reverts commit 9793ca2bf2700ffef99c7961dc604cc03f60831f.

Reason for revert: known to not work on mac, at least.

Original change's description:
> Deploy git 2.18 to canary buildbot slaves.
> 
> R=​hinoka
> 
> Bug:  851505 
> Change-Id: I2c235d3d2bb0ae43dacd177f73a387d25c1a6e80
> Reviewed-on: https://chromium-review.googlesource.com/1168128
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

TBR=hinoka@chromium.org,tandrii@chromium.org

Change-Id: I4b2954ed4abf5bced9f95f1e50490ef9a3f5c56c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851505 
Reviewed-on: https://chromium-review.googlesource.com/1168602
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/28982623f8e1fb5caed57f17efede475c89da466/scripts/slave/cipd_bootstrap_v2.py
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/477c78a99beff1a2cb211f905b69db7eeb4c6c44

commit 477c78a99beff1a2cb211f905b69db7eeb4c6c44
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Thu Aug 09 00:52:19 2018
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/15a5a77db4128acdc9f7f21e6b2ce9ed8f022a4d

commit 15a5a77db4128acdc9f7f21e6b2ce9ed8f022a4d
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 01:35:55 2018

Reland "Deploy git 2.18 to depot_tools on a bleeding edge."

This is a reland of d61997d37c8f7cc68080f39d4b516fb7b269b46c

Original change's description:
> Deploy git 2.18 to depot_tools on a bleeding edge.
> 
> R=hinoka
> 
> Bug:  851505 
> Change-Id: I3e13da0ec736fb3da4f4a95c71ed07c9a4fd0eca
> Reviewed-on: https://chromium-review.googlesource.com/1168130
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

Bug:  851505 
Change-Id: I1d8d8062bad14f531d6b0a8bf1a3ce0875afd5b0
Reviewed-on: https://chromium-review.googlesource.com/1168353
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/15a5a77db4128acdc9f7f21e6b2ce9ed8f022a4d/bootstrap/win/manifest_bleeding_edge.txt
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7048be851657dd23284b06d7ba6af576e89abdfa

commit 7048be851657dd23284b06d7ba6af576e89abdfa
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 09 22:32:02 2018

Roll src/third_party/depot_tools dd5051fa529e..15a5a77db412 (4 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd5051fa529e..15a5a77db412


git log dd5051fa529e..15a5a77db412 --date=short --no-merges --format='%ad %ae %s'
2018-08-09 tandrii@chromium.org Reland "Deploy git 2.18 to depot_tools on a bleeding edge."
2018-08-09 tandrii@chromium.org Revert "Deploy git 2.18 to depot_tools on a bleeding edge."
2018-08-08 tandrii@chromium.org Deploy git 2.18 to depot_tools on a bleeding edge.
2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@15a5a77db412

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:851505 , chromium:851505 , chromium:851505 
TBR=agable@chromium.org

Change-Id: I925476691895d7caf2e8e3ada3144e0312302025
Reviewed-on: https://chromium-review.googlesource.com/1169114
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581928}
[modify] https://crrev.com/7048be851657dd23284b06d7ba6af576e89abdfa/DEPS
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/421bc3f84d1b4fdbfaf50d8b48449e0e871a6421

commit 421bc3f84d1b4fdbfaf50d8b48449e0e871a6421
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 16 00:00:51 2018

Deploy git 2.18 to prod win depot_tools users.

R=hinoka

Bug:  851505 
Change-Id: I355334c2a84f175452ff7c17f6b080d2815f0f4c
Reviewed-on: https://chromium-review.googlesource.com/1168131
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/421bc3f84d1b4fdbfaf50d8b48449e0e871a6421/bootstrap/win/manifest.txt
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e345a1f7494bee312c7137476c048c784d10dd9

commit 1e345a1f7494bee312c7137476c048c784d10dd9
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 16 02:15:21 2018

Roll src/third_party/depot_tools ba883cb5ed14..421bc3f84d1b (5 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba883cb5ed14..421bc3f84d1b


git log ba883cb5ed14..421bc3f84d1b --date=short --no-merges --format='%ad %ae %s'
2018-08-16 tandrii@chromium.org Deploy git 2.18 to prod win depot_tools users.
2018-08-16 tandrii@chromium.org Register expect_tests in gclient config.
2018-08-15 rsesek@chromium.org Clarify OWNERS error if using TBR.
2018-08-15 vadimsh@chromium.org Revert "[cipd] Check CIPD client hash against pinned SHA256 during updates."
2018-08-15 jbudorick@chromium.org Grant everyone owners on README.recipes.md.


Created with:
  gclient setdep -r src/third_party/depot_tools@421bc3f84d1b

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:851505 , chromium:870166 
TBR=agable@chromium.org

Change-Id: I110a7cde5025f046174287878daebf69c48a7286
Reviewed-on: https://chromium-review.googlesource.com/1176682
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583501}
[modify] https://crrev.com/1e345a1f7494bee312c7137476c048c784d10dd9/DEPS

Comment 24 by tandrii@chromium.org, Aug 17 

Status:

1. Windows devs have 2.18 with depot_tools.
2. issue 875453 is filed to make gclient configure protocol.version 2 iff git client is >=2.18.
3. Bots, unfortunately, still use 2.17. This is because of Mac regression, which I didn't yet resolve.

Idea:
We should similar stuff to (2) in global git config on bots once 2.18 is stuck there.

Comment 25 by tandrii@chromium.org, Sep 19

Status: WontFix (was: Started)
Wont Fix. because 2.19 has been released already:
issue 887141
►

Sign in to add a comment