New issue
Advanced search Search tips

Issue 851503 link

Starred by 1 user
Status: Fixed
Owner:
creis@chromium.org
Closed: Jun 2018
Cc:
rdevlin....@chromium.org
alex...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

ExtensionSet::GetExtensionOrAppByURL doesn't support extension filesystem or blob URLs

Project Member Reported by creis@chromium.org, Jun 11 2018 
ExtensionSet::GetExtensionOrAppByURL and ExtensionSet::GetExtensionOrAppIDByURL look up an extension object based on GURL::SchemeIs.  That returns filesystem: for a URL like filesystem:chrome-extension://abcd, so it doesn't find the associated extension.  Similar for blob URLs.

Not sure if there's much user-observable impact, but this came up in another review.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8441547e38709d7a5c804b23375fccd0fed622

commit 2c8441547e38709d7a5c804b23375fccd0fed622
Author: Charlie Reis <creis@chromium.org>
Date: Wed Jun 13 01:41:00 2018

Make ExtensionSet::GetExtensionOrApp{ID}ByURL support filesystem URLs.

Filesystem and blob URLs don't have a chrome-extension:// scheme
according to GURL, but do according to url::Origin.

BUG= 851503 ,  840857 

Change-Id: Ia5e4cf5f9c3d04dff07d4f31da6d774d574af653
Reviewed-on: https://chromium-review.googlesource.com/1093402
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566677}
[modify] https://crrev.com/2c8441547e38709d7a5c804b23375fccd0fed622/extensions/common/extension_set.cc
[modify] https://crrev.com/2c8441547e38709d7a5c804b23375fccd0fed622/extensions/common/extension_set_unittest.cc

Comment 2 by creis@chromium.org, Jun 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment