Issue metadata
Sign in to add a comment
|
Media Controls: overflow menu has a scrollbar |
||||||||||||||||||||||
Issue descriptionSTR: 1. open https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html 2. click on the overflow menu button Expected result: overflow menu appears as a popup/overlay without a scrollbar Actual result: overflow menu has a scrollbar
,
Jul 26
Issue 867890 has been merged into this issue.
,
Jul 26
,
Jul 26
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
,
Jul 30
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
,
Aug 2
Friendly ping to get an update as it is marked as RB stable. Thanks..!
,
Aug 7
,
Aug 7
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2ed29c1db216ab48cd57e92a220d4be4c1a1842 commit e2ed29c1db216ab48cd57e92a220d4be4c1a1842 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Aug 09 23:10:16 2018 [Media Controls] Remove CSS rules causing overflow menu scrollbar This CL removes some obselete sizing-* CSS rules that were inadvertently causing a scrollbar to appear in the overflow menu at certain zoom levels. Bug: 851492 Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810 Reviewed-on: https://chromium-review.googlesource.com/1168394 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581948} [modify] https://crrev.com/e2ed29c1db216ab48cd57e92a220d4be4c1a1842/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
Aug 10
Able to reproduce the issue on ubuntu 17.10 using chrome build without fix. Verified the fix on Ubuntu 17.10 using Chrome version #70.0.3518.0 as per the comment #0. Attaching screen shot for reference. Observed that overflow menu appeared as a popup/overlay without a scrollbar. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Aug 10
steimel@, pls request a merge to M69 if cl is safe to merge. Thank you.
,
Aug 13
,
Aug 13
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
Approving merge to M69 branch 3497 based on comment #12. Pls merge ASAP and mark bug as fixed after the merge if nothing else is pending. Thank you.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f commit 5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f Author: Tommy Steimel <steimel@chromium.org> Date: Mon Aug 13 20:29:58 2018 [Media Controls] Remove CSS rules causing overflow menu scrollbar This CL removes some obselete sizing-* CSS rules that were inadvertently causing a scrollbar to appear in the overflow menu at certain zoom levels. Bug: 851492 Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810 Reviewed-on: https://chromium-review.googlesource.com/1168394 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581948}(cherry picked from commit e2ed29c1db216ab48cd57e92a220d4be4c1a1842) Reviewed-on: https://chromium-review.googlesource.com/1173077 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#585} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
Aug 13
,
Aug 16
Verified the fix on Ubuntu 17.10 using Chrome version #69.0.3497.42 as per the comment #0. Attaching screen shot for reference. Observed that overflow menu appeared as a popup/overlay without a scrollbar. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mlamouri@chromium.org
, Jul 23