New issue
Advanced search Search tips

Issue 851492 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: overflow menu has a scrollbar

Project Member Reported by mlamouri@chromium.org, Jun 11 2018

Issue description

STR:
 1. open https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
 2. click on the overflow menu button
 
Expected result: overflow menu appears as a popup/overlay without a scrollbar

Actual result: overflow menu has a scrollbar
 
screenshot.png
43.4 KB View Download
Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 861716  has been merged into this issue.
Issue 867890 has been merged into this issue.
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable RegressedIn-69 Pri-1 Type-Bug-Regression
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 26

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Target-69
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 30

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-69
Friendly ping to get an update as it is marked as RB stable.
Thanks..!

Status: Started (was: Assigned)
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ed29c1db216ab48cd57e92a220d4be4c1a1842

commit e2ed29c1db216ab48cd57e92a220d4be4c1a1842
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Aug 09 23:10:16 2018

[Media Controls] Remove CSS rules causing overflow menu scrollbar

This CL removes some obselete sizing-* CSS rules that were
inadvertently causing a scrollbar to appear in the overflow menu at
certain zoom levels.

Bug:  851492 
Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810
Reviewed-on: https://chromium-review.googlesource.com/1168394
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581948}
[modify] https://crrev.com/e2ed29c1db216ab48cd57e92a220d4be4c1a1842/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Labels: TE-Verified-M70 TE-Verified-70.0.3518.0
Able to reproduce the issue on ubuntu 17.10 using chrome build without fix.

Verified the fix on Ubuntu 17.10 using Chrome version #70.0.3518.0 as per the comment #0.
Attaching screen shot for reference.
Observed that overflow menu appeared as a popup/overlay without a scrollbar.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
851492.png
462 KB View Download
steimel@, pls request a merge to M69 if cl is safe to merge. Thank you.
Labels: Merge-Request-69
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #12. Pls merge ASAP and mark bug as fixed after the merge if nothing else is pending.  Thank you.
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 13

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f

commit 5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Aug 13 20:29:58 2018

[Media Controls] Remove CSS rules causing overflow menu scrollbar

This CL removes some obselete sizing-* CSS rules that were
inadvertently causing a scrollbar to appear in the overflow menu at
certain zoom levels.

Bug:  851492 
Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810
Reviewed-on: https://chromium-review.googlesource.com/1168394
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581948}(cherry picked from commit e2ed29c1db216ab48cd57e92a220d4be4c1a1842)
Reviewed-on: https://chromium-review.googlesource.com/1173077
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#585}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5c5e362d008cfc0760ebe4f10de54f2ff0fbab8f/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
Labels: TE-Verified-M69 TE-Verified-69.0.3497.42
Verified the fix on Ubuntu 17.10 using Chrome version #69.0.3497.42 as per the comment #0.
Attaching screen shot for reference.
Observed that overflow menu appeared as a popup/overlay without a scrollbar.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
851492@M69.png
509 KB View Download

Sign in to add a comment