New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851484 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Origin Trial for Event Timing

Project Member Reported by npm@chromium.org, Jun 11 2018

Issue description

This is a tracker bug for patches needed for the Origin Trial for Event Timing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26177caf2422fca75e0d3fe793dc04f66bf8213c

commit 26177caf2422fca75e0d3fe793dc04f66bf8213c
Author: Nicolas Pena <npm@chromium.org>
Date: Mon Jun 11 17:46:24 2018

Add an Origin Trial for EventTiming

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/24d3456d-7bef-4df7-ad83-7fe3b3d3d9f4%40chromium.org?utm_medium=email&utm_source=footer

Bug: 841224,  851484 
Change-Id: I2defd6455096b6d63898fa966c0a36ec68a749ee
Reviewed-on: https://chromium-review.googlesource.com/1087777
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566045}
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[add] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/eventtiming-origin-trial-interfaces.html
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/renderer/core/timing/performance.idl
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/renderer/core/timing/performance_event_timing.idl
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/26177caf2422fca75e0d3fe793dc04f66bf8213c/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a8dcc9f9b94cbade61024e5d1c130737f666a7

commit 05a8dcc9f9b94cbade61024e5d1c130737f666a7
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 15 01:48:19 2018

EventTiming: Implement processingEnd and fix duration

This CL adds |processingEnd| to EventTiming, and it is computed as the
time when we have finished dispatching an event. The |duration| is fixed
to be the time the next swap promise is resolved. It is computed in the
WindowPerformance to avoid complicating the lifetime of the EventTiming
class and to facilitate grouping multiple event entries into a single
swap promise.

This CL also fixes the computation of DOMHighResTimeStamp to be aligned
with the other entry types: we use MonotonicTimeToDOMHighResTimeStamp to
clamp first and then subtract instead of subtracting first and then
clamping.

The layouttests are modified to force swap promises to be resolved
before onload when needed. To allow serving a delayed resource via php,
the tests are moved to http/tests .

Bug: 841224,  851484 
Change-Id: I684b165ef5840b9d4da17258b0a1cc796ec43fcb
Reviewed-on: https://chromium-review.googlesource.com/1095736
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567512}
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observer-manual.html
[add] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-observer-manual-childframe.html
[rename] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[add] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/slow-image.php
[delete] https://crrev.com/5588ab78a51fb17bd52ff1fe2c142b26ef80b730/third_party/WebKit/LayoutTests/performance/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/event_timing.cc
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/performance_entry.cc
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/performance_entry.h
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/performance_event_timing.cc
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/performance_event_timing.h
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/performance_event_timing.idl
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/05a8dcc9f9b94cbade61024e5d1c130737f666a7/third_party/blink/renderer/core/timing/window_performance_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb0340843831ff66336ae4357d302969d194d078

commit fb0340843831ff66336ae4357d302969d194d078
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Jun 20 22:50:51 2018

EventTiming: Implement First Input

This CL implements the PerformanceEventTiming entry of type "firstInput"
whose explanation can be found at:
https://github.com/WICG/event-timing#first-input-timing

Bug: 841224,  851484 
Change-Id: I40d799f1920ec2fc5fb9140a5e5faec6642a7f03
Reviewed-on: https://chromium-review.googlesource.com/1103230
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569062}
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance.h
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance_entry.cc
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance_entry.h
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance_event_timing.cc
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/performance_event_timing.h
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/fb0340843831ff66336ae4357d302969d194d078/third_party/blink/renderer/core/timing/window_performance_test.cc

Comment 4 by npm@chromium.org, Jun 21 2018

Labels: Merge-Request-68
Requesting a merge of the CLs listed in this bug to M68. These affect only the code of the EventTiming  origin trial.
Cc: bmcquade@chromium.org rbyers@chromium.org igrigo...@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
+ a few of the folks who care about this merge.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 21 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please comment on why this is critical for M68 vs waiting for M69?
Labels: -Merge-Review-68 Merge-Approved-68
As discussed over email, this is behind a finch flag and will be rolled out to a very small % of developers as origin trial, who are only deploying it to a small % of users. Since it's finch gated, and it's currently blocking, I'm fine with the merge to M68. Branch:3440
Note that this is behind an origin trial flag, which is distinct from a finch flag.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e1aec1830cea9c1668db8751db1ac800b6b780d

commit 2e1aec1830cea9c1668db8751db1ac800b6b780d
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 22 16:16:54 2018

[M68 merge] Add an Origin Trial for EventTiming

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/24d3456d-7bef-4df7-ad83-7fe3b3d3d9f4%40chromium.org?utm_medium=email&utm_source=footer

(cherry picked from commit 26177caf2422fca75e0d3fe793dc04f66bf8213c)

Bug: 841224,  851484 
Change-Id: I2defd6455096b6d63898fa966c0a36ec68a749ee
Reviewed-on: https://chromium-review.googlesource.com/1087777
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566045}
Reviewed-on: https://chromium-review.googlesource.com/1112209
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#488}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[add] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/eventtiming-origin-trial-interfaces.html
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/renderer/core/timing/performance.idl
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/renderer/core/timing/performance_event_timing.idl
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/tools/metrics/histograms/enums.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a97439c6585e5a699fb18e7a9744fc6c88dc74

commit a8a97439c6585e5a699fb18e7a9744fc6c88dc74
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 22 16:23:51 2018

[M68 merge] EventTiming: Implement processingEnd and fix duration

This CL adds |processingEnd| to EventTiming, and it is computed as the
time when we have finished dispatching an event. The |duration| is fixed
to be the time the next swap promise is resolved. It is computed in the
WindowPerformance to avoid complicating the lifetime of the EventTiming
class and to facilitate grouping multiple event entries into a single
swap promise.

This CL also fixes the computation of DOMHighResTimeStamp to be aligned
with the other entry types: we use MonotonicTimeToDOMHighResTimeStamp to
clamp first and then subtract instead of subtracting first and then
clamping.

The layouttests are modified to force swap promises to be resolved
before onload when needed. To allow serving a delayed resource via php,
the tests are moved to http/tests .

(cherry picked from commit 05a8dcc9f9b94cbade61024e5d1c130737f666a7)

Bug: 841224,  851484 
Change-Id: I684b165ef5840b9d4da17258b0a1cc796ec43fcb
Reviewed-on: https://chromium-review.googlesource.com/1095736
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567512}
Reviewed-on: https://chromium-review.googlesource.com/1112213
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#489}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observer-manual.html
[add] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-observer-manual-childframe.html
[rename] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[add] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/slow-image.php
[delete] https://crrev.com/2e1aec1830cea9c1668db8751db1ac800b6b780d/third_party/WebKit/LayoutTests/performance/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/event_timing.cc
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/performance_entry.cc
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/performance_entry.h
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/performance_event_timing.cc
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/performance_event_timing.h
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/performance_event_timing.idl
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/a8a97439c6585e5a699fb18e7a9744fc6c88dc74/third_party/blink/renderer/core/timing/window_performance_test.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134e010889e3695fc33584486eb21dde4a362f4d

commit 134e010889e3695fc33584486eb21dde4a362f4d
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 22 17:24:56 2018

[M68 merge] EventTiming: Implement First Input

This CL implements the PerformanceEventTiming entry of type "firstInput"
whose explanation can be found at:
https://github.com/WICG/event-timing#first-input-timing

(cherry picked from commit fb0340843831ff66336ae4357d302969d194d078)

Bug: 841224,  851484 
Change-Id: I40d799f1920ec2fc5fb9140a5e5faec6642a7f03
Reviewed-on: https://chromium-review.googlesource.com/1103230
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#569062}
Reviewed-on: https://chromium-review.googlesource.com/1112215
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#494}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance.h
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance_entry.cc
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance_entry.h
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance_event_timing.cc
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/performance_event_timing.h
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/134e010889e3695fc33584486eb21dde4a362f4d/third_party/blink/renderer/core/timing/window_performance_test.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e1e0dac7e69fd57053f8988f64b1903727f5a8

commit c9e1e0dac7e69fd57053f8988f64b1903727f5a8
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 22 19:17:37 2018

EventTiming: create at most one firstInput entry

This CL introduces a bool |first_input_detected_| to make sure that we do not
create more than one PerformanceEventTiming entry of type 'firstInput'. Before,
there could be many entries of this type dispatched to PerformanceObservers when
the first input occurred after onload and |first_input_timing_| would never be
set.

Bug: 841224,  851484 
Change-Id: I293d3de1ac052eaab9297d725ce0211f242aaf5a
Reviewed-on: https://chromium-review.googlesource.com/1111914
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569727}
[add] https://crrev.com/c9e1e0dac7e69fd57053f8988f64b1903727f5a8/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html
[modify] https://crrev.com/c9e1e0dac7e69fd57053f8988f64b1903727f5a8/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/c9e1e0dac7e69fd57053f8988f64b1903727f5a8/third_party/blink/renderer/core/timing/window_performance.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7111eada104774df0884c162edbbab273c4a355

commit f7111eada104774df0884c162edbbab273c4a355
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jun 22 19:23:07 2018

EventTiming: create at most one firstInput entry

This CL introduces a bool |first_input_detected_| to make sure that we do not
create more than one PerformanceEventTiming entry of type 'firstInput'. Before,
there could be many entries of this type dispatched to PerformanceObservers when
the first input occurred after onload and |first_input_timing_| would never be
set.

Bug: 841224,  851484 
Change-Id: I293d3de1ac052eaab9297d725ce0211f242aaf5a
Reviewed-on: https://chromium-review.googlesource.com/1111914
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#569727}(cherry picked from commit c9e1e0dac7e69fd57053f8988f64b1903727f5a8)
Reviewed-on: https://chromium-review.googlesource.com/1112180
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#496}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[add] https://crrev.com/f7111eada104774df0884c162edbbab273c4a355/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html
[modify] https://crrev.com/f7111eada104774df0884c162edbbab273c4a355/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/f7111eada104774df0884c162edbbab273c4a355/third_party/blink/renderer/core/timing/window_performance.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4679d0a38913ec026695393dbb4ca09c68731df1

commit 4679d0a38913ec026695393dbb4ca09c68731df1
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Jun 26 21:38:15 2018

EventTiming: Add UseCounter to track explicit usage

This CL adds a UseCounter that tracks the two ways to use EventTiming
explicitly:
* getEntriesByType or getEntriesByName with event/firstInput.
* Having PerformanceObservers of event/firstInput.

Bug:  851484 
Change-Id: I8c2af71d089dbbf7db87b94b8b5d9f56e1699998
Reviewed-on: https://chromium-review.googlesource.com/1115511
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570539}
[modify] https://crrev.com/4679d0a38913ec026695393dbb4ca09c68731df1/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/4679d0a38913ec026695393dbb4ca09c68731df1/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/4679d0a38913ec026695393dbb4ca09c68731df1/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/4679d0a38913ec026695393dbb4ca09c68731df1/tools/metrics/histograms/enums.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ed43bfcdac96c02f2e95966880cde1374ebee3b

commit 7ed43bfcdac96c02f2e95966880cde1374ebee3b
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Jun 26 21:47:23 2018

[M68 merge]EventTiming: Add UseCounter to track explicit usage

This CL adds a UseCounter that tracks the two ways to use EventTiming
explicitly:
* getEntriesByType or getEntriesByName with event/firstInput.
* Having PerformanceObservers of event/firstInput.

(cherry picked from commit 4679d0a38913ec026695393dbb4ca09c68731df1)

Bug:  851484 
Change-Id: I8c2af71d089dbbf7db87b94b8b5d9f56e1699998
Reviewed-on: https://chromium-review.googlesource.com/1115511
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570539}
Reviewed-on: https://chromium-review.googlesource.com/1115732
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#540}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/7ed43bfcdac96c02f2e95966880cde1374ebee3b/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/7ed43bfcdac96c02f2e95966880cde1374ebee3b/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/7ed43bfcdac96c02f2e95966880cde1374ebee3b/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/7ed43bfcdac96c02f2e95966880cde1374ebee3b/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)
Current plan is to NOT extend the Origin Trial and trial ends with M71. We should now add bits to the explainer based on feedback, present to WebPerf to gather consensus, write an actual spec, and do another Origin Trial or ship.

Sign in to add a comment