New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 851477 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 807388



Sign in to add a comment

rendering.mobile timing out on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 11 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

rendering.mobile failing on multiple builders

Builders failed on: 
- Android Nexus5 Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf
- Android Nexus5X Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5X%20Perf
- Android Nexus5X WebView Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5X%20WebView%20Perf
- Android Nexus6 WebView Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus6%20WebView%20Perf
- Android One Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20One%20Perf

It looks like the failure started happening after https://chromium-review.googlesource.com/1085852, where the maps page set was collapsed into the rendering page set. Initially aquarium_20k was failing. Then, after https://chromium-review.googlesource.com/1089038 and was submitted, we started having problems where archive files were missing from the page set. Then in the same roll, the missing archive files were fixed in https://chromium-review.googlesource.com/1090755 while more pages were added to the set in https://chromium-review.googlesource.com/1089290 and https://chromium-review.googlesource.com/1089459.

 
Cc: sadrul@chromium.org vmi...@chromium.org amyqiu@google.com
It looks like this benchmark has been failing for the last week or so (~20 runs) on all mobile platforms.

Comment 2 by sadrul@chromium.org, Jun 11 2018

Cc: nednguyen@chromium.org
+nednguyen@

Is it possible that the timeouts are actually happening because the pageset is getting too large?
sadrul@, this is definitely happening because the pageset is too large for the 3h timeout that we currently have assigned to it, but we can just bump up the timeout for this specific story. This problem should also disappear once we do a better job of sharding our benchmarks on the waterfall (which should be coming down the pipeline in the next few weeks).

Based on the logs, it looks like 229 stories are emitting "[ RUN" strings and there are about ~250 total stories (based on the story JSON file here: https://cs.chromium.org/chromium/src/tools/perf/page_sets/data/rendering_mobile.json?type=cs&q=rendering_mobile.json&sq=package:chromium&g=0&l=169).

Given this, it seems like bumping out the timeout from 3h to 4h should be sufficient to get this passing again.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a00eb9ae215443651d1efab720097719cea417

commit 24a00eb9ae215443651d1efab720097719cea417
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Jun 11 17:25:31 2018

Increase the timeout of rendering.mobile from 3h to 4h

The benchmark was timing out after several other benchmarks were
collapsed into it.

CC=​sadrul@chromium.org,vmiura@chromium.org,amyqiu@chromium.org

TBR=nednguyen@chromium.org

Bug:  851477 
Change-Id: Iffd966955223b581a7b3edd468ba1ee2f6b14e9b
Reviewed-on: https://chromium-review.googlesource.com/1094990
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#566041}
[modify] https://crrev.com/24a00eb9ae215443651d1efab720097719cea417/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/24a00eb9ae215443651d1efab720097719cea417/tools/perf/core/perf_data_generator.py

Status: Fixed (was: Available)
Looks like increasing the timeout fixed the problem.

Comment 6 by kbr@chromium.org, Jun 29 2018

Blockedon: 807388

Sign in to add a comment