New issue
Advanced search Search tips

Issue 851475 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove Cocoa version of JS dialogs

Project Member Reported by a...@chromium.org, Jun 11 2018

Issue description

MacViews is used for dialogs now, and the Cocoa code is unused. It should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5df5cc2691569e63583827e963d3cea984b741cc

commit 5df5cc2691569e63583827e963d3cea984b741cc
Author: Avi Drissman <avi@chromium.org>
Date: Mon Jun 11 23:37:38 2018

Remove the Cocoa version of JS dialogs.

MacViews is used for dialogs now (as of M66 or so),
and the Cocoa code is unused.

BUG= 851475 

Change-Id: Ia9d5fa050a5b9acf56865ace18d0469b0c9b603a
Reviewed-on: https://chromium-review.googlesource.com/1095324
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566204}
[modify] https://crrev.com/5df5cc2691569e63583827e963d3cea984b741cc/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5df5cc2691569e63583827e963d3cea984b741cc/chrome/browser/ui/android/javascript_dialog_android.cc
[delete] https://crrev.com/7bcdd21d287741c1d2c7d28c2159b91de8fb35ee/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
[modify] https://crrev.com/5df5cc2691569e63583827e963d3cea984b741cc/chrome/browser/ui/javascript_dialogs/javascript_dialog.h
[delete] https://crrev.com/7bcdd21d287741c1d2c7d28c2159b91de8fb35ee/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h
[delete] https://crrev.com/7bcdd21d287741c1d2c7d28c2159b91de8fb35ee/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm
[delete] https://crrev.com/7bcdd21d287741c1d2c7d28c2159b91de8fb35ee/chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc
[modify] https://crrev.com/5df5cc2691569e63583827e963d3cea984b741cc/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

Comment 2 by a...@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)

Sign in to add a comment