New issue
Advanced search Search tips

Issue 851472 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 843236



Sign in to add a comment

ios_web_view_inttests WebViewKvoTest are all failing on iOS12.

Project Member Reported by justincohen@chromium.org, Jun 11 2018

Issue description

Lots of failing web tests.

ios_web_int:
DownloadTaskImplTest.FailureInTheBeginning
CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableDisabled
DownloadTaskImplTest.FileDeletion
DownloadTaskImplTest.FailureInTheMiddle
DownloadTaskImplTest.MimeTypeChange
DownloadTaskImplTest.SmallResponseDownload
DownloadTaskImplTest.HttpResponseCode
DownloadTaskImplTest.Cookie
DownloadTaskImplTest.LargeResponseDownload
DownloadTaskImplTest.Cancelling
DownloadTaskImplTest.DownloadTaskShutdown
DownloadTaskImplTest.EmptyContentDownload
DownloadTaskImplTest.UnknownLengthContentDownload
CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableEnabled
DownloadTaskImplTest.Restarting

ios_web_view_int:
WebViewKvoTest.Loading
WebViewKvoTest.CanGoBackForward
passed tests
WebViewKvoTest.URLs
+Crashes


 
Cc: jzw@chromium.org
+ John for WebViewKvoTest test failures
CRWWebControllerPageScrollStateTest are flaky on all platforms
Owner: eugene...@chromium.org
Status: Started (was: Untriaged)
I will fix DownloadTaskImplTest
WebViewKvoTest tests use WaitForWebViewLoadCompletionOrTimeout to wait until the navigation is completed, which does not seem to be right. We should use WaitForWebViewContainingTextOrTimeout instead.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd9d7826f090169c81fbc1595ec7bf31ac186c36

commit cd9d7826f090169c81fbc1595ec7bf31ac186c36
Author: Eugene But <eugenebut@google.com>
Date: Tue Jun 12 21:28:00 2018

Fix DownloadTaskImplTest for iOS 12.

iOS 12 calls private undocumented method from NSHTTPCookieStorage, which
needs to be stubbed in CRWFakeNSURLSessionTask in order to use fake task
with NSHTTPCookieStorage.

Bug:  851472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59b676090786a65e902ccd98a5fea85e2b191fed
Reviewed-on: https://chromium-review.googlesource.com/1097570
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566577}
[modify] https://crrev.com/cd9d7826f090169c81fbc1595ec7bf31ac186c36/ios/web/test/fakes/crw_fake_nsurl_session_task.mm

Cc: -jzw@chromium.org
Owner: jzw@chromium.org
Status: Assigned (was: Started)
Assigning to John to fix or disable ios/web_view tests for iOS 12.
Labels: -Pri-3 Pri-1
eugenebut@ DownloadManagerEGTest::testSucessfullDownload is also failing on iOS 12.  Would you like me to create a separate bug for that?
Yes, please. DownloadManagerEGTest::testSucessfullDownload seems like orthogonal to WebViewKvoTest failures.
Summary: ios_web_view_inttests WebViewKvoTest are all failing on iOS12. (was: iOS12: Various web tests failing.)
OK, update bug title for jzw@

Comment 10 by jzw@chromium.org, Jun 13 2018

I'll take a look. Thanks.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b393474c3a9f80e4acaa9cec429dbf652eb218

commit e4b393474c3a9f80e4acaa9cec429dbf652eb218
Author: Justin Cohen <justincohen@google.com>
Date: Thu Jun 14 00:37:59 2018

[ios] Disable failing WebViewKvoTest on iOS12.

Bug:  851472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2adc8be4d6b007eff22acac225c1f6c4952334a
Reviewed-on: https://chromium-review.googlesource.com/1099882
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567065}
[modify] https://crrev.com/e4b393474c3a9f80e4acaa9cec429dbf652eb218/ios/web_view/test/web_view_kvo_inttest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b76fc5cc56b64e75d0ebd7a1c825653fb5a7a1aa

commit b76fc5cc56b64e75d0ebd7a1c825653fb5a7a1aa
Author: John Z Wu <jzw@chromium.org>
Date: Fri Jun 15 20:55:08 2018

Fix WebViewKvoTests by using WaitForWebViewContainingTextOrTimeout.

Navigation may not occur right away after tapping on links, causing
WaitForWebViewLoadCompletionOrTimeout to return immediately.

Bug:  851472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5bf173f696dceeebc0118105a74fd0b19ebb27c9
Reviewed-on: https://chromium-review.googlesource.com/1103008
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567782}
[modify] https://crrev.com/b76fc5cc56b64e75d0ebd7a1c825653fb5a7a1aa/ios/web_view/test/web_view_kvo_inttest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment